Generalize and refactor colorblindfriendly.py
#155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s into generalize-cbf * 'generalize-cbf' of github.com:jaredsampson/pymol-scripts: Improve logging to stdout. Prevent duplicate printing of added colors when adding multiple palettes. Ignore readability-improving palette whitespace for flake8. Add matplotlib reference for viridis and magma palettes. Add viridis and magma palettes (h/t Yehudi Bloch). Generalize color/menu handling to enable additional palettes.
* master: (21 commits) Fix combo box not showing all options. New virtual screening interface based on AutoDock Vina ecosystem. Update vina.py added initial docstring, revised import section, and added .py to name Create cgoCircle Update tmalign.py List plugins documentation (Pymol-Scripts#146) Fix support for multiple objects selection Add support for multiple object haystack in findseq.py Independent color and as_putty options for color_by_conservation.py (Pymol-Scripts#145) Add output message for findseq + don't create empty selection when seq was not found (Pymol-Scripts#141) Update tmalign.py Outline plugin version 0.2 minor fix An attempt to improve plugin the plugin documentations. Delete documentation.md Rename documentation.html to documentation.md Create documentation.html Port dynoplot to Qt Add tab-completion to findseq ...
JarrettSJohnson
approved these changes
Feb 10, 2025
Contributor
JarrettSJohnson
left a comment
JarrettSJohnson
left a comment
There was a problem hiding this comment.
Thanks Jared. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the format used for declaring the color palettes using two new NamedTuple classes,
PaletteandPaletteColor. In addition to the original "colorblind" palette, it also adds "viridis" and "magma" palettes (as suggested by Yehudi Bloch).Tested with PyMOL versions 3.0 and 2.5.7.