Skip to content

Conversation

@pslacerda
Copy link
Member

Now the option color and as_putty works independent of each other.

Now the option color and as_putty works independent of each other.
@pslacerda
Copy link
Member Author

Put your @JarrettSJohnson and @speleo3 as reviewers because I don't know if I can accept my own PR.

@speleo3
Copy link
Contributor

speleo3 commented Jun 9, 2024

Why did you remove the _self argument? It's key for using pymol2.PyMOL instances. See the tests for usage examples.

@pslacerda
Copy link
Member Author

It was my fault.

This cmd reference should be changed to _self?

r = cmd.get_raw_alignment(aln)

@speleo3
Copy link
Contributor

speleo3 commented Jun 9, 2024

This cmd reference should be changed to _self?

Yes

@pslacerda
Copy link
Member Author

Done.

Copy link
Contributor

@speleo3 speleo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pslacerda pslacerda removed the request for review from JarrettSJohnson June 9, 2024 21:02
@pslacerda pslacerda merged commit 9ed2717 into master Jun 9, 2024
@pslacerda pslacerda deleted the patch-color_by_conservation branch June 9, 2024 21:03
jaredsampson added a commit to jaredsampson/pymol-scripts that referenced this pull request Feb 10, 2025
* master: (21 commits)
  Fix combo box not showing all options.
  New virtual screening interface based on AutoDock Vina ecosystem.
  Update vina.py
  added initial docstring, revised import section, and added .py to name
  Create cgoCircle
  Update tmalign.py
  List plugins documentation (Pymol-Scripts#146)
  Fix support for multiple objects selection
  Add support for multiple object haystack in findseq.py
  Independent color and as_putty options for color_by_conservation.py (Pymol-Scripts#145)
  Add output message for findseq + don't create empty selection when seq was not found (Pymol-Scripts#141)
  Update tmalign.py
  Outline plugin version 0.2
  minor fix
  An attempt to improve plugin the plugin documentations.
  Delete documentation.md
  Rename documentation.html to documentation.md
  Create documentation.html
  Port dynoplot to Qt
  Add tab-completion to findseq
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants