fix (#118) and (#130) #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @wadx2019 - Do you know anyone else who is using this plugin and can confirm that your fixes work? |
Author
|
Hi, @speleo3 . No, but I have tested the new version in both win10 and ubuntu platforms, and did not import any other python packages, even any other functions and classes. |
Author
|
Besides, only one .py file is updated. So I believe it can run successfully without any destruction on most platforms. |
Contributor
|
OK thanks. Your changes seem pretty straightforward, so let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed issues #118 and #130 that led to the terrible usage experience of autodock_plugin in win10. Moreover, the new code has been tested successfully in several docking cases. So, please approve my PR.
Much thanks.