Skip to content

inserttable() to use str(datetime) rather than repr() #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cito merged 1 commit into from
Jan 25, 2026
Merged

inserttable() to use str(datetime) rather than repr() #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ext/pgconn.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
#include "pginternal.h"
#include "pgmodule.h"

/* Needs to be after Python.h */
#include "datetime.h"

/* Deallocate connection object. */
static void
conn_dealloc(connObject *self)
Expand Down Expand Up @@ -789,6 +792,11 @@ conn_inserttable(connObject *self, PyObject *args, PyObject *kwds)

encoding = PQclientEncoding(self->cnx);

PyDateTime_IMPORT;
if (PyErr_Occurred()) {
return NULL; /* pass the error */
}

/* pre-allocate some memory for the query buffer */
if (!init_char_buffer(&buffer, 4096)) {
Py_DECREF(iter_row);
Expand Down Expand Up @@ -990,6 +998,14 @@ conn_inserttable(connObject *self, PyObject *args, PyObject *kwds)
ext_char_buffer_s(&buffer, t);
Py_DECREF(s);
}
else if (PyDate_Check(item) || PyDateTime_Check(item) ||
PyTime_Check(item) || PyDelta_Check(item)) {
PyObject *s = PyObject_Str(item);
const char *t = PyUnicode_AsUTF8(s);

ext_char_buffer_s(&buffer, t);
Py_DECREF(s);
}
else {
PyObject *s = PyObject_Repr(item);
const char *t = PyUnicode_AsUTF8(s);
Expand Down
7 changes: 7 additions & 0 deletions tests/test_classic_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

from __future__ import annotations

import datetime as dt
import os
import threading
import time
Expand Down Expand Up @@ -1897,6 +1898,12 @@ def test_inserttable_no_column(self):
self.c.inserttable('test', data, [])
self.assertEqual(self.get_back(), [])

def test_inserttable_datetime_adapt(self):
data = [(dt.date(1999,1,2), dt.time(11,12,13))]
self.c.inserttable('test', data, ['dt', 'ti'])
self.assertEqual([i[4:6] for i in self.get_back()],
[tuple(str(j) for j in i) for i in data])

def test_inserttable_only_one_column(self):
data: list[tuple] = [(42,)] * 50
self.c.inserttable('test', data, ['i4'])
Expand Down