fix memory leak and Inserttable batch - #92
Merged
Conversation
added 2 commits
January 4, 2026 18:22
This won't be an issue in real life, but this keeps the test suite clean. Found with: PYTHONPATH=pg valgrind --leak-check=full pytest ./tests/test_classic_connection.py::TestInserttable::test_inserttable_with_invalid_table_name ./tests/test_classic_connection.py::TestInserttable::test_inserttable_with_invalid_column_name
This is especially important for nonlocal DBs, where libpq would do a
round trip for each row.
For a local DB, this is already ~10% faster.
$ time PYTHNOPATH=pg python3.11 -c "import pg; db=pg.DB(host='/tmp'); db.inserttable('t', [[1]]*9999999)"
real 0m2,079s
justinpryzby
marked this pull request as ready for review
January 24, 2026 02:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.