Skip to content

Conversation

@LKaemmerling
Copy link
Member

@LKaemmerling LKaemmerling commented Oct 22, 2020

Signed-off-by: Lukas Kämmerling lukas.kaemmerling@hetzner-cloud.de

This MR basically brings the same improvements @rdohms did within PromPHP/prometheus_client_php#17 to the push_gateway client.

Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
@LKaemmerling LKaemmerling marked this pull request as ready for review October 22, 2020 12:59
@LKaemmerling LKaemmerling requested a review from rdohms October 22, 2020 12:59
Copy link
Member

@rdohms rdohms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
@LKaemmerling LKaemmerling merged commit a353ed1 into master Oct 26, 2020
@LKaemmerling LKaemmerling deleted the improve-type-hinting branch October 26, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants