Redis - Metrics collection should not write anything #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iKsSs
force-pushed
the
redis-read-only
branch
from
9508d1e to
82ac6ae
Compare
LKaemmerling
previously approved these changes
Dec 1, 2024
Member
LKaemmerling
left a comment
LKaemmerling
left a comment
There was a problem hiding this comment.
LGTM! Good catch, thank you!
Contributor
Author
|
@mp3000mp could you please take a look? |
Contributor
Author
|
please wait until #169 is merged :) |
iKsSs
force-pushed
the
redis-read-only
branch
from
933e620 to
31cff83
Compare
Signed-off-by: Jakub Pastuszek <jakub.pastuszek@invia.cz>
iKsSs
force-pushed
the
redis-read-only
branch
from
ac3ef40 to
93fcfac
Compare
LKaemmerling
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the Redis master node for writing and slave node(s) for reading - if we try to collect metrics
Redis::collectSummaries()sometimes tries to delete some keys from storage, which is impossible on the READ ONLY node.