Add PDO storage adapter. #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashrsm
force-pushed
the
pdo
branch
2 times, most recently
from
8979034 to
c6a53bd
Compare
Member
|
Hey @slashrsm, this looks amazing! Could you maybe make the CI Pass and add the new adapter to the Readme? |
Contributor
Author
|
Thank you for your feedback @LKaemmerling! I think that I fixed everything that originated in this PR. The remaining failures seem to be unrelated. Do you want me to set up MySQL based tests in GH actions as well? |
Member
|
Yes it would be good to have the tests for MySQL as well - maybe also we should support Postgres? (Shouldn't be a big effort) |
Contributor
Author
|
@LKaemmerling I updated GH actions to run both SQLite and MySQL tests. It appears that you need to approve the changed job. |
Signed-off-by: Janez Urevc <janez@tag1.com>
Signed-off-by: Janez Urevc <janez@tag1.com>
Signed-off-by: Janez Urevc <janez@tag1.com>
Signed-off-by: Janez Urevc <janez@tag1.com>
Signed-off-by: Janez Urevc <janez@tag1.com>
Signed-off-by: Janez Urevc <janez@tag1.com>
Signed-off-by: Janez Urevc <janez@tag1.com>
Signed-off-by: Janez Urevc <janez@tag1.com>
Signed-off-by: Janez Urevc <janez@tag1.com>
LKaemmerling
reviewed
Aug 5, 2024
LKaemmerling
approved these changes
Aug 5, 2024
Member
LKaemmerling
left a comment
LKaemmerling
left a comment
There was a problem hiding this comment.
Really great job! Thank you!
Contributor
Author
|
Awesome! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case where we need to use a database as a storage backend - yes, we are aware that this won't be as performant as Redis or APC. Unfortunately we are not able to use either of those. And we are expecting a limited number of metrics.
The provided adapter passes the standard test suite with both SQLite and MySQL. The latter obviously won't run on GH actions, but I am happy to add that configuration if the maintainers will show preparedness to merge this.