-
Notifications
You must be signed in to change notification settings - Fork 110
Comparing changes
Open a pull request
base repository: PromPHP/prometheus_client_php
base: v2.11.0
head repository: PromPHP/prometheus_client_php
compare: main
- 18 commits
- 19 files changed
- 18 contributors
Commits on Oct 18, 2024
-
- Add PostgreSQL support in Storage/PDO.php (#162)
- Add PostgreSQL tests in github workflow - Fix type hints and types in doc blocks - Add phpstan ignoreErrors for Redis: phpstan/phpstan#11728 Signed-off-by: Alex <2646298@mail.ru>
Configuration menu - View commit details
-
Copy full SHA for 600f6df - Browse repository at this point
Copy the full SHA 600f6dfView commit details -
Ensure that label values are strings in APCNg adapter (#159)
* Ensure that label values are strings in APCNg adapter APCNg is crashing if the label value provided wasn't a string, but something that can be coerced to string (such as int). The problem occurs in two different places: - when a metric is emitted, the `storeLabelKeys()` calls into `addItemToKey()` which has its second parameter type hinted as a `string` and throws a type error if anything else is passed. This results in partially stored state; - when trying to scrape metrics with partially stored state, the `APCng::collect()` will try to build all the permutations and expect all the key-value pairs for labels to exist, but numeric label values aren't persisted and so it will cause the `Undefined array key` error as reported in #154; This change ensures that label values are cast to the string type before encoding them and using as APC keys. Signed-off-by: Garry Filakhtov <garry.filakhtov@bigcommerce.com> * Fix PHPStan issues Signed-off-by: Garry Filakhtov <garry.filakhtov@bigcommerce.com> --------- Signed-off-by: Garry Filakhtov <garry.filakhtov@bigcommerce.com>
Configuration menu - View commit details
-
Copy full SHA for 50b70a6 - Browse repository at this point
Copy the full SHA 50b70a6View commit details
Commits on Dec 2, 2024
-
Ignore phpstan argument.type lint in test (#169)
Signed-off-by: Matias Ylipelto <129368437+lianatech-matias-ylipelto@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 12af805 - Browse repository at this point
Copy the full SHA 12af805View commit details -
Use explicit nullable type parameters (#168)
Signed-off-by: Matias Ylipelto <129368437+lianatech-matias-ylipelto@users.noreply.github.com> Co-authored-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
Configuration menu - View commit details
-
Copy full SHA for 6d7328e - Browse repository at this point
Copy the full SHA 6d7328eView commit details -
Redis - Metrics collection should not write anything (#165)
Signed-off-by: Jakub Pastuszek <jakub.pastuszek@invia.cz> Co-authored-by: Jakub Pastuszek <jakub.pastuszek@invia.cz>
Configuration menu - View commit details
-
Copy full SHA for d6233cc - Browse repository at this point
Copy the full SHA d6233ccView commit details -
Redis ACL AUTH two argument supporting. (#167)
* Redis ACL AUTH two argument supporting. Signed-off-by: Gennadii Chernykh <ragnarek45@gmail.com> Signed-off-by: Gennadii Chernykh <gennadii.chernykh@eglobal-group.com> * Redis ACL AUTH two argument supporting. Signed-off-by: Gennadii Chernykh <ragnarek45@gmail.com> Signed-off-by: Gennadii Chernykh <gennadii.chernykh@eglobal-group.com> * Fix not using empty in Redis Adapter * Fix not using empty in RedisNg Adapter --------- Signed-off-by: Gennadii Chernykh <gennadii.chernykh@eglobal-group.com> Co-authored-by: Gennadii Chernykh <gennadii.chernykh@eglobal-group.com> Co-authored-by: Lukas Kämmerling <github@lukas-kaemmerling.de>
Configuration menu - View commit details
-
Copy full SHA for abe6bbb - Browse repository at this point
Copy the full SHA abe6bbbView commit details
Commits on Dec 10, 2024
-
Correctly handle empty username for Redis/RedisNg AUTH (#170)
Signed-off-by: Reda <reda.bouchaala@printify.com>
Configuration menu - View commit details
-
Copy full SHA for 3f8e4ff - Browse repository at this point
Copy the full SHA 3f8e4ffView commit details
Commits on Mar 3, 2025
-
Use PHP 8.4 for tests and fix phpstan issue (#176)
* Use PHP 8.4 for tests and fix phpstan issue Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de> * Update actions Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de> * Migrate phpunit configuration Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de> --------- Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
Configuration menu - View commit details
-
Copy full SHA for f191801 - Browse repository at this point
Copy the full SHA f191801View commit details -
Catch invalid JSON from Redis and throw an error (#174)
* Catch invalid JSON from Redis and throw an error Signed-off-by: Vsevolod <vmalygin@adsterra.com> * was added a custom json exception for metrics Signed-off-by: Vsevolod <vmalygin@adsterra.com> * refactoring Signed-off-by: Vsevolod <vmalygin@adsterra.com> * Update src/Prometheus/Exception/MetricJsonException.php --------- Signed-off-by: Vsevolod <vmalygin@adsterra.com> Co-authored-by: Vsevolod <vmalygin@adsterra.com> Co-authored-by: Lukas Kämmerling <github@lukas-kaemmerling.de> Co-authored-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
Configuration menu - View commit details
-
Copy full SHA for 4f71eb1 - Browse repository at this point
Copy the full SHA 4f71eb1View commit details -
Bump min php Version to 7.4, fix PHPstan issues
Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
Configuration menu - View commit details
-
Copy full SHA for 7912087 - Browse repository at this point
Copy the full SHA 7912087View commit details -
feat: add metric name to MetricsRegistrationException (#163)
Signed-off-by: Simon Podlipsky <simon@podlipsky.net> Co-authored-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
Configuration menu - View commit details
-
Copy full SHA for 1d8b02b - Browse repository at this point
Copy the full SHA 1d8b02bView commit details
Commits on Mar 5, 2025
-
Prevent php error when data was removed from redis (#149)
This code was already in redis storage but not in redisNg Co-authored-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
Configuration menu - View commit details
-
Copy full SHA for 381753d - Browse repository at this point
Copy the full SHA 381753dView commit details -
APCng storage - avoid worst-case memory usage in buildPermutationTree (…
…#123) * APCng storage - avoid worst-case memory usage in buildPermutationTree Signed-off-by: Josh Hoffer <jhoffer@datava.com> * Fix PHPstan errors Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de> --------- Signed-off-by: Josh Hoffer <jhoffer@datava.com> Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de> Co-authored-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
Configuration menu - View commit details
-
Copy full SHA for 3e4811f - Browse repository at this point
Copy the full SHA 3e4811fView commit details
Commits on Apr 14, 2025
-
Changed the parent class for MetricNotFoundException to improve the e…
…xception hierarchy (#181) Signed-off-by: Vsevolod <vmalygin@adsterra.com> Co-authored-by: Vsevolod <vmalygin@adsterra.com> Co-authored-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
Configuration menu - View commit details
-
Copy full SHA for 5fed794 - Browse repository at this point
Copy the full SHA 5fed794View commit details -
create index if not exist to prevent duplicate error (#180)
Signed-off-by: Sergio Acevedo <SergioAcevedo05@Protonmail.com> Co-authored-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
Configuration menu - View commit details
-
Copy full SHA for f242784 - Browse repository at this point
Copy the full SHA f242784View commit details -
Login into DockerHub to avoid rate limits
Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
Configuration menu - View commit details
-
Copy full SHA for e7e1720 - Browse repository at this point
Copy the full SHA e7e1720View commit details -
Storage/Redis & RedisNG: Remove usage of str_replace to get metrics a…
Configuration menu - View commit details
-
Copy full SHA for a283aea - Browse repository at this point
Copy the full SHA a283aeaView commit details
Commits on Jul 2, 2025
-
CI: Test against Redis 8 (#188)
Signed-off-by: simonhammes <simonhammes@users.noreply.github.com> Co-authored-by: simonhammes <simonhammes@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 93b023f - Browse repository at this point
Copy the full SHA 93b023fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.11.0...main