Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PromPHP/prometheus_client_php
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c7c174b
Choose a base ref
...
head repository: PromPHP/prometheus_client_php
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ad2a85f
Choose a head ref
  • 1 commit
  • 2 files changed
  • 2 contributors

Commits on Dec 20, 2023

  1. [RenderTextFormat] Allow value errors to be rendered as comments (#142) 

    * [RenderTextFormat] Allow value errors to be rendered as comments.

Redis and RedisNg allow samples with mismatching labels to be stored, which could cause ValueError to be thrown when
rendering. Rendering would fail as a result, which is not ideal.

- Change render() to accept an optional $silent parameter. When set to true, render the errors as comments instead of
  throwing them and failing the whole operation.

Signed-off-by: Joe Cai <joe.cai@bigcommerce.com>
---------

Signed-off-by: Joe Cai <joe.cai@bigcommerce.com>
Co-authored-by: Lukas Kämmerling <github@lukas-kaemmerling.de>
    @joec4i @LKaemmerling
    joec4i and LKaemmerling authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    ad2a85f View commit details
    Browse the repository at this point in the history
Loading