Fix PHP notice: Undefined index: samples (#128)

pluk77 · LKaemmerling · web-flow · commit 735ace7ec6f5 · 2023-11-06T13:38:23.000+01:00
* Fix PHP notice: Undefined index: samples

collectHistograms() in the storage adapters does not define ['samples'] as the default array keys and as such a notice is thrown when the MetricFamilySamples::__construct($data) is called when no samples are available.

* added space

---------

Co-authored-by: Lukas Kämmerling &lt;lukas.kaemmerling@hetzner-cloud.de&gt;
diff --git a/src/Prometheus/MetricFamilySamples.php b/src/Prometheus/MetricFamilySamples.php
@@ -40,8 +40,10 @@ public function __construct(array $data)
         $this->type = $data['type'];
         $this->help = $data['help'];
         $this->labelNames = $data['labelNames'];
-        foreach ($data['samples'] as $sampleData) {
-            $this->samples[] = new Sample($sampleData);
+        if (isset($data['samples'])) {
+            foreach ($data['samples'] as $sampleData) {
+                $this->samples[] = new Sample($sampleData);
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,10 @@ public function __construct(array $data)`
`40`	`40`	`$this->type = $data['type'];`
`41`	`41`	`$this->help = $data['help'];`
`42`	`42`	`$this->labelNames = $data['labelNames'];`
`43`		`- foreach ($data['samples'] as $sampleData) {`
`44`		`- $this->samples[] = new Sample($sampleData);`
	`43`	`+ if (isset($data['samples'])) {`
	`44`	`+ foreach ($data['samples'] as $sampleData) {`
	`45`	`+ $this->samples[] = new Sample($sampleData);`
	`46`	`+ }`
`45`	`47`	`}`
`46`	`48`	`}`
`47`	`49`