Add rank parameter to get_historic_observations#26
Open
gbabineau wants to merge 2 commits intoProjectBabbler:masterfrom
Open
Add rank parameter to get_historic_observations#26gbabineau wants to merge 2 commits intoProjectBabbler:masterfrom
gbabineau wants to merge 2 commits intoProjectBabbler:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #25 which I created. I needed to get the first observation of a taxa on the date specified for
get_historic_observations. This functionality is provided in the eBird API but was not made available in this python wrapper.I attempted to follow the coding standards. The changes are simple.
I also tested that the existing functionality still works - either as default, or by passing the parameter it had been defaulting to.
I hope this is useful! I appreciate the work to put this wrapper together and am glad to contribute back.
and the results are correct, showing evening, morning, evening.