Skip to content

Commit a02bbfa

Browse files
amai2012danmar
authored andcommitted
Fixed cppcheck-opensource#5492 (Fix small bug in MathLib::isFloat())
1 parent dea4107 commit a02bbfa

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

‎lib/mathlib.cpp‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,10 @@ bool MathLib::isFloat(const std::string &s)
131131
case LEADING_DECIMAL:
132132
if (std::isdigit(*it))
133133
state=BASE_DIGITS2;
134+
else if (*it=='e' || *it=='E')
135+
state=E;
136+
else
137+
return false;
134138
break;
135139
case BASE_DIGITS1:
136140
if (*it=='e' || *it=='E')

‎test/testmathlib.cpp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,6 +368,9 @@ class TestMathLib : public TestFixture {
368368
ASSERT_EQUALS(false , MathLib::isFloat(" 0. "));
369369
ASSERT_EQUALS(false , MathLib::isFloat(" 0."));
370370

371+
ASSERT_EQUALS(false , MathLib::isFloat("0.."));
372+
ASSERT_EQUALS(false , MathLib::isFloat("..0.."));
373+
ASSERT_EQUALS(false , MathLib::isFloat("..0"));
371374
ASSERT_EQUALS(true , MathLib::isFloat("0.0"));
372375
ASSERT_EQUALS(true , MathLib::isFloat("-0."));
373376
ASSERT_EQUALS(true , MathLib::isFloat("+0."));

0 commit comments

Comments
 (0)