Skip to content

Commit 6bb8dd6

Browse files
committed
assign function parameters: only show warning when --enable=warning or --enable=style is used. Ticket: cppcheck-opensource#2930
1 parent 082c48d commit 6bb8dd6

3 files changed

Lines changed: 6 additions & 1 deletion

File tree

‎lib/checkautovariables.cpp‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ void CheckAutoVariables::autoVariables()
9494
{
9595
const SymbolDatabase *symbolDatabase = _tokenizer->getSymbolDatabase();
9696

97+
const bool reportWarnings(_settings->isEnabled("warning"));
98+
9799
const std::size_t functions = symbolDatabase->functionScopes.size();
98100
for (std::size_t i = 0; i < functions; ++i) {
99101
const Scope * scope = symbolDatabase->functionScopes[i];
@@ -107,7 +109,8 @@ void CheckAutoVariables::autoVariables()
107109
const Variable * var = tok->tokAt(5)->variable();
108110
if (checkRvalueExpression(var, tok->tokAt(6)))
109111
errorAutoVariableAssignment(tok->next(), false);
110-
} else if (Token::Match(tok, "[;{}] %var% =") &&
112+
} else if (reportWarnings &&
113+
Token::Match(tok, "[;{}] %var% =") &&
111114
isPtrArg(tok->next()) &&
112115
Token::Match(tok->next()->variable()->typeStartToken(), "struct| %type% * %var% [,)]") &&
113116
!pointerIsDereferencedInScope(tok->next()->variable(), scope)) {

‎lib/settings.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ std::string Settings::addEnabled(const std::string &str)
7575

7676
static std::set<std::string> id;
7777
if (id.empty()) {
78+
id.insert("warning");
7879
id.insert("style");
7980
id.insert("performance");
8081
id.insert("portability");

‎test/testautovariables.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ class TestAutoVariables : public TestFixture {
4040

4141
Settings settings;
4242
settings.inconclusive = inconclusive;
43+
settings.addEnabled("warning");
4344

4445
// Tokenize..
4546
Tokenizer tokenizer(&settings, this);

0 commit comments

Comments
 (0)