Skip to content

Conversation

@henryjonathanquispe
Copy link
Contributor

@henryjonathanquispe henryjonathanquispe commented Feb 12, 2025

Issue & Reproduction Steps

  1. Create a screen form
  2. Add signature control
  3. Mark as required
  4. Add more controls like: (Line input, text area)
  5. Create a case
  6. Open the task
  7. Change the controls to auto save will be enabled
  8. Clear the draft
  9. Refresh the page
  10. Click on submit button

Current Behavior

The signature control disappears after refresh the page. If the field is required the form cannot be completed

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
..

@pmPaulis
Copy link
Contributor

@ryancooley @boliviacoca
I create this ticket to review the CIDeploy issue
https://processmaker.atlassian.net/browse/SCO-27407
About the PHP unit is a issue not related with the changes

Setting Cache (Tests\Feature\Cache\SettingCache)
 ✘ Invalidate on saved
   │
   │ Failed asserting that ProcessMaker\Models\Setting Object &000000000001ee110000000000000000 (
   │     'connection' => 'processmaker'

Regards,

@boliviacoca
Copy link
Contributor

@pmPaulis pmPaulis self-requested a review February 12, 2025 19:59
@pmPaulis
Copy link
Contributor

@henryjonathanquispe
the code looks good but I need to test in the cideploy.
Regards,

@processmaker-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pmPaulis
Copy link
Contributor

QA server K8S was successfully deployed https://ci-e930b45f36.engk8s.processmaker.net/

@pmPaulis
Copy link
Contributor

pmPaulis commented Feb 14, 2025

Team,
This is working as expected, f5 a lot of times always show the signature control
Captura de pantalla 2025-02-14 a las 11 41 36 a  m
Regards,

@ryancooley ryancooley merged commit 6533d5e into release-2025-winter Feb 14, 2025
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants