Swift Tools (Version 5 Support) + missing mobile content product#950
Open
ArkadiGiniApps wants to merge 1 commit intoProcedureKit:developmentfrom
Open
Swift Tools (Version 5 Support) + missing mobile content product#950ArkadiGiniApps wants to merge 1 commit intoProcedureKit:developmentfrom
ArkadiGiniApps wants to merge 1 commit intoProcedureKit:developmentfrom
Conversation
…Add support form missing mobile content product
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based largely on @richardpiazza work in #945
This PR updates the Swift Package.swift file to the tools version 5 format.
And adds support form missing mobile content product
Along with that change, the minimum supported platforms are added (using platforms: []), and the supported language versions are listed (using swiftLanguageVersions: []).
Due to now listed the minimum os support, files in ProcedureKitCoreDataTests needed to have a '@available' attribute applied making sure the tests where only run on supported platforms. (Primarily due to the use of NSPersistentContainer).
Also, since some build environments may not understand what an .xcdatamodeld file is, I've added the TestEntity class definitions, as well as, creating the NSManagedObjectModel definition in code. This allows the tests to run and pass while using the swift test command.
These updates were tested with Xcode 11.1 using swift packages.
(Could relate to #939)
@danthorpe There's and issue i haven't managed to resolve with the Location target:
The pointer address passing doesn't work with swift 5, this needs to be addressed before merging the PR, maybe you can take a look at this, frankly i'm a bit stuck here