Skip to content

Use spaces instead of tabs#2889

Merged
TylerLeonhardt merged 4 commits into
PowerShell:masterfrom
xtqqczze:tabs-to-spaces
Aug 28, 2020
Merged

Use spaces instead of tabs#2889
TylerLeonhardt merged 4 commits into
PowerShell:masterfrom
xtqqczze:tabs-to-spaces

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 15, 2020

Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze marked this pull request as draft August 15, 2020 21:10
@TylerLeonhardt

Copy link
Copy Markdown
Member

please revert vscode.proposed.d.ts . That must have tabs because that file is kept up to date with a file in the vscode repo which uses tabs

@TylerLeonhardt TylerLeonhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@corbob

corbob commented Aug 17, 2020

Copy link
Copy Markdown
Contributor

Would it be an idea to add editorconfig to the recommended extensions?

Alternatively: should the settings being put in editorconfig just be put in the vscode workspace settings? PSES uses editorconfig presumably because you could use any editor with it, but is it safe to assume anyone editing this project is using vscode?

@rjmholt

rjmholt commented Aug 17, 2020

Copy link
Copy Markdown
Contributor

Seems like if it works just as well in .editorconfig, it's best to put in there

@xtqqczze xtqqczze marked this pull request as ready for review August 28, 2020 21:11
@TylerLeonhardt

Copy link
Copy Markdown
Member

Thanks!

@TylerLeonhardt TylerLeonhardt merged commit 9267ac9 into PowerShell:master Aug 28, 2020
@xtqqczze xtqqczze deleted the tabs-to-spaces branch August 28, 2020 23:14
@xtqqczze

Copy link
Copy Markdown
Contributor Author

@corbob thanks for the suggestion, see #2922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants