Skip to content

Add Async suffix to async methods - #792

Merged
TylerLeonhardt merged 1 commit into
PowerShell:2.0.0from
dee-see:rename-async
Nov 13, 2018
Merged

TylerLeonhardt merged 1 commit into
PowerShell:2.0.0from
dee-see:rename-async

Conversation

@dee-see

@dee-see Dominic (dee-see) commented Nov 8, 2018 •

Copy link
Copy Markdown
Contributor

Fixes #177 in the 2.0.0 branch.

Rename all (hopefully!) async methods with an -Async suffix

@TylerLeonhardt

Copy link
Copy Markdown
Member

out of curiosity... did you automate this change?

@dee-see

Copy link
Copy Markdown
Contributor Author

Heh, semi-automatic. I found all the method signatures missing the -Async suffix with a regex search in VSCode and then cycled through the results and used the built-in rename function.

There has to be a Visual Studio extension that offers that code fix but I didn't have my Windows/full VS machine with me and there weren't that many things to rename so I went on with that.

@rkeithhill Keith Hill (rkeithhill) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that is the largest PR I've ever reviewed. :-) LGTM.

@rjmholt Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Dominic (@dee-see) !

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TylerLeonhardt TylerLeonhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got comments, abstract classes, not tests.... this PR is great! Thanks for doing this!

@TylerLeonhardt
TylerLeonhardt merged commit 22159d4 into PowerShell:2.0.0 Nov 13, 2018
@dee-see
Dominic (dee-see) deleted the rename-async branch November 14, 2018 21:08
TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this pull request Dec 14, 2018
Rob Holt (rjmholt) pushed a commit to rjmholt/PowerShellEditorServices that referenced this pull request Jan 18, 2019
Rob Holt (rjmholt) pushed a commit to rjmholt/PowerShellEditorServices that referenced this pull request Jan 18, 2019
[Ignore] no need for package sources (PowerShell#803)

[Ignore] add null check for version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants