Repository navigation
Add Async suffix to async methods - #792
Conversation
|
out of curiosity... did you automate this change? |
|
Heh, semi-automatic. I found all the method signatures missing the There has to be a Visual Studio extension that offers that code fix but I didn't have my Windows/full VS machine with me and there weren't that many things to rename so I went on with that. |
Keith Hill (rkeithhill)
left a comment
There was a problem hiding this comment.
I'm pretty sure that is the largest PR I've ever reviewed. :-) LGTM.
Rob Holt (rjmholt)
left a comment
There was a problem hiding this comment.
LGTM! Thanks Dominic (@dee-see) !
Patrick Meinecke (SeeminglyScience)
left a comment
There was a problem hiding this comment.
LGTM!
TylerLeonhardt
left a comment
There was a problem hiding this comment.
You got comments, abstract classes, not tests.... this PR is great! Thanks for doing this!
[Ignore] no need for package sources (PowerShell#803) [Ignore] add null check for version
Fixes #177 in the 2.0.0 branch.
Rename all (hopefully!) async methods with an -
Asyncsuffix