Skip to content

Enable building universal (x64,arm64) binaries for MacOS #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 5 commits into from
Mar 9, 2021
Merged

Enable building universal (x64,arm64) binaries for MacOS #64

adityapatwardhan merged 5 commits into from
Mar 9, 2021

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Feb 28, 2021 •
edited
Loading

Created cmakefile specifying both x64 and arm64 architectures. Tested locally on M1 MacBookPro using file to verify the resulting dylib is universal.

PS> file /Users/steve/repos/PowerShell-Native/src/powershell-unix/libpsl-native.dylib
/Users/steve/repos/PowerShell-Native/src/powershell-unix/libpsl-native.dylib: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64:Mach-O 64-bit dynamically linked shared library arm64]
/Users/steve/repos/PowerShell-Native/src/powershell-unix/libpsl-native.dylib (for architecture x86_64):	Mach-O 64-bit dynamically linked shared library x86_64
/Users/steve/repos/PowerShell-Native/src/powershell-unix/libpsl-native.dylib (for architecture arm64):	Mach-O 64-bit dynamically linked shared library arm64

Needed to switch to vmimage for MacOS 10.15+ which has XCode12 to support building universal binary for M1 and x64.

@SteveL-MSFT SteveL-MSFT mentioned this pull request Feb 28, 2021
Merged
22 tasks
PaulHigin
PaulHigin approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan adityapatwardhan changed the title enable building universal (x64,arm64) binaries for MacOS Enable building universal (x64,arm64) binaries for MacOS Mar 8, 2021
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Mar 8, 2021 •
edited by TravisEz13
Loading

@SteveL-MSFT - can you verify that the release build succeeds?

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Mar 9, 2021

@adityapatwardhan verified release build succeeds and library is universal

@adityapatwardhan adityapatwardhan merged commit 2ad0b58 into PowerShell:master Mar 9, 2021
@SteveL-MSFT SteveL-MSFT deleted the build-m1 branch March 10, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

+1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SteveL-MSFT @adityapatwardhan @TravisEz13 @PaulHigin