Make tests that rely on executable path use common code to calculate path #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmenaga
approved these changes
Feb 14, 2020
| && locale-gen && update-locale \ | ||
| # remove powershell package | ||
| && rm /tmp/powershell.deb \ | ||
| && ln -sf /opt/microsoft/powershell/7-preview/pwsh /usr/bin/pwsh \ |
There was a problem hiding this comment.
unlike other Debians in this PR, here creation of '/usr/bin/pwsh' sym link is remoevd and /usr/bin/pwsh-lts is not created. Why?
There was a problem hiding this comment.
same for all lts ubuntu dockerfiles in this PR.
Member
Author
There was a problem hiding this comment.
The deb file creates it here.
Co-Authored-By: Andrew <anmenaga@microsoft.com>
TravisEz13
added a commit
that referenced
this pull request
Feb 20, 2020
Co-Authored-By: Andrew <anmenaga@microsoft.com> Co-authored-by: Andrew <anmenaga@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
Dockerfile,.sh,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.