Skip to content

Add module AccountManagement #9926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iSazonov wants to merge 4 commits into from
Closed

Add module AccountManagement #9926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c14994a
Add AccountManagement New-User cmdlet
iSazonov Jun 17, 2019
09a2916
Add AccountManagement Remove-User cmdlet
iSazonov Dec 25, 2019
9635fb8
Add AccountManagement Get-User cmdlet
iSazonov Dec 25, 2019
4384f8b
Add Search-Account
iSazonov Dec 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions assets/files.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1964,6 +1964,11 @@
<File Id="fil6B026F6D5210498B99E5F14386F4F90B" KeyPath="yes" Source="$(env.ProductSourcePath)\Modules\ThreadJob\Microsoft.PowerShell.ThreadJob.dll" />
Copy link
Collaborator

@PoshChan PoshChan Dec 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iSazonov, your last commit had 7 failures in PowerShell-CI-windows
(These are 5 of the failures)

Validate AccountManagement user cmdlets.Validate New-User.Can create New-User with only name

Expected exactly 'TestUserNew', but got $null.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1: line 27
27:                 $result.Name | Should -BeExactly TestUserNew

Validate AccountManagement user cmdlets.Validate New-User.Can create New-User with password

Expected exactly 'TestUserNew', but got $null.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1: line 38
38:                 $result.Name | Should -BeExactly TestUserNew

Validate AccountManagement user cmdlets.Validate New-User.Can create New-User with explicit properties in local machine

Expected exactly 'samq2', but got $null.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1: line 54
54:                 $result.Name | Should -BeExactly "samq2"

Validate AccountManagement user cmdlets.Validate Remove-User.Can remove user account with pipeline

Expected an exception, with FullyQualifiedErrorId 'UserAlreadyRemoved,Microsoft.PowerShell.Commands.RemoveUserCommand' to be thrown, but no exception was thrown.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1: line 137
137:                 { $userIdentity | Remove-User -ErrorAction Stop } | Should -Throw -ErrorId "UserAlreadyRemoved,Microsoft.PowerShell.Commands.RemoveUserCommand"

Validate AccountManagement user cmdlets.Validate Remove-User.Can remove user account with parameter

Expected no exception to be thrown, but an exception "Cannot bind argument to parameter 'Identity' because it is null." was thrown from D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1:141 char:41
    +                 { Remove-User -Identity $userIdentity -ErrorAction St ?
    +                                         ~~~~~~~~~~~~~.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1: line 141
141:                 { Remove-User -Identity $userIdentity -ErrorAction Stop } | Should -Not -Throw

Copy link
Collaborator

@PoshChan PoshChan Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iSazonov, your last commit had 7 failures in PowerShell-CI-windows
(These are 5 of the failures)

Validate AccountManagement user cmdlets.Validate New-User.Can create New-User with only name

Expected exactly 'TestUserNew', but got $null.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1: line 27
27:                 $result.Name | Should -BeExactly TestUserNew

Validate AccountManagement user cmdlets.Validate New-User.Can create New-User with password

Expected exactly 'TestUserNew', but got $null.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1: line 38
38:                 $result.Name | Should -BeExactly TestUserNew

Validate AccountManagement user cmdlets.Validate New-User.Can create New-User with explicit properties in local machine

Expected exactly 'samq2', but got $null.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1: line 54
54:                 $result.Name | Should -BeExactly "samq2"

Validate AccountManagement user cmdlets.Validate Remove-User.Can remove user account with pipeline

Expected no exception to be thrown, but an exception "Cannot access a disposed object.
Object name: 'PrincipalContext'." was thrown from D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1:134 char:35
    + ?               { $userIdentity | Remove-User -ErrorAction Stop } | Sho ?
    +                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1: line 134
134:                 { $userIdentity | Remove-User -ErrorAction Stop } | Should -Not -Throw

Validate AccountManagement user cmdlets.Validate Remove-User.Can remove user account with parameter

Expected no exception to be thrown, but an exception "Cannot bind argument to parameter 'Identity' because it is null." was thrown from D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1:141 char:41
    +                 { Remove-User -Identity $userIdentity -ErrorAction St ?
    +                                         ~~~~~~~~~~~~~.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.AccountManagement\AccountManagement.User.Tests.ps1: line 141
141:                 { Remove-User -Identity $userIdentity -ErrorAction Stop } | Should -Not -Throw

</Component>
</Directory>
<Directory Name="Microsoft.PowerShell.AccountManagement" Id="dir4289FEACBE1F4E4FA23EAD4444519B68">
<Component Id="cmp95D7A116B7DA414E9523D62857970D7E" Guid="{3bfbcd45-4145-4e27-bfbd-728e59c3a77c}">
<File Id="fil775887F2B9B74EEBA525B5F1393DC86E" KeyPath="yes" Source="$(env.ProductSourcePath)\Modules\Microsoft.PowerShell.AccountManagement\Microsoft.PowerShell.AccountManagement.psd1" />
</Component>
</Directory>
</Directory>
<Directory Id="dir20D076755BAF7EA1D1A980368C4F81A2" Name="assets">
<Component Id="cmpF877117B22A73BEA3855701E9BEB20D2" Guid="{14AFE4AD-F727-4154-9FC0-BCB8E238E6F4}">
Expand Down Expand Up @@ -3074,6 +3079,15 @@
<Component Id="cmp391B9B0E71AF4A99BFE7260F811AFAC4" Guid="{2d8c929e-37e0-488c-8793-246b36559bd3}">
<File Id="filB279809149164F37A0C48A01D092529A" KeyPath="yes" Source="$(env.ProductSourcePath)\mscordaccore_$(var.FileArchitecture)_$(var.FileArchitecture)_4.700.19.56402.dll" />
</Component>
<Component Id="cmpF5B68E7720D142DA9A0C902F1A0C8119" Guid="{e2886651-5d4b-484f-ab7f-25fae8004d29}">
<File Id="fil3507409BA9A9472DB7986B4E4052C1FF" KeyPath="yes" Source="$(env.ProductSourcePath)\Microsoft.PowerShell.AccountManagement.dll" />
</Component>
<Component Id="cmp6C9E3FD6DEC340B9A07917F40769166A" Guid="{b086b0cd-fa90-4d32-8dbe-ff7fab2f1723}">
<File Id="fil56B0C12D3CCB4E919D20321706A9BF0A" KeyPath="yes" Source="$(env.ProductSourcePath)\Microsoft.PowerShell.AccountManagement.xml" />
</Component>
<Component Id="cmp6C18B4BA345540A19A6FF05D1FD6295C" Guid="{fe6151d2-b699-459e-8f86-86484bec9a13}">
<File Id="fil7C5FB850347B466FB6765046348CD437" KeyPath="yes" Source="$(env.ProductSourcePath)\Microsoft.PowerShell.AccountManagement.pdb" />
</Component>
</DirectoryRef>
</Fragment>
<Fragment>
Expand Down Expand Up @@ -4064,6 +4078,12 @@
<ComponentRef Id="cmpAC984FA3A67247BC996F60290C87D0A1" />
<ComponentRef Id="cmp2E32A6E773F543F0A150B972F8D3E23A" />
<ComponentRef Id="cmp391B9B0E71AF4A99BFE7260F811AFAC4" />
<ComponentRef Id="cmpDF735CE07E554BE982062B4CDF560E5A" />
<ComponentRef Id="cmp6696252F9CA14F6A9ECAFA30B97209A3" />
<ComponentRef Id="cmp95D7A116B7DA414E9523D62857970D7E" />
<ComponentRef Id="cmpF5B68E7720D142DA9A0C902F1A0C8119" />
<ComponentRef Id="cmp6C9E3FD6DEC340B9A07917F40769166A" />
<ComponentRef Id="cmp6C18B4BA345540A19A6FF05D1FD6295C" />
</ComponentGroup>
</Fragment>
</Wix>
21 changes: 21 additions & 0 deletions src/Microsoft.PowerShell.AccountManagement/Microsoft.PowerShell.AccountManagement.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
<Import Project="..\..\PowerShell.Common.props" />
<PropertyGroup>
<Description>PowerShell's Microsoft.PowerShell.AccountManagement project</Description>
<NoWarn>$(NoWarn);CS1570</NoWarn>
<AssemblyName>Microsoft.PowerShell.AccountManagement</AssemblyName>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\System.Management.Automation\System.Management.Automation.csproj" />
</ItemGroup>

<PropertyGroup>
<DefineConstants>$(DefineConstants);CORECLR</DefineConstants>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="System.DirectoryServices.AccountManagement" Version="4.7.0" />
</ItemGroup>

</Project>
Loading