Add support for -l to pwsh so that it is compatible with POSIX shell expectations
#9528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
iSazonov
reviewed
May 4, 2019
src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs
Show resolved
Hide resolved
src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs
Show resolved
Hide resolved
iSazonov
reviewed
May 4, 2019
src/Microsoft.PowerShell.ConsoleHost/resources/ManagedEntranceStrings.resx
Outdated
Show resolved
Hide resolved
…Strings.resx Co-Authored-By: SteveL-MSFT <slee@microsoft.com>
iSazonov
approved these changes
May 4, 2019
iSazonov
added
the
CL-General
joeyaiello
added
Review - Committee
Collaborator
|
Based on new RFC I think this should be |
Member
Author
|
@iSazonov the problem with calling it |
Collaborator
|
Linux users will very confused to see long form in docs - they expect "login" but get another. The current solution looks like a hoax. I think we could discuss this in your RFC. |
Member
Author
|
@iSazonov bring up as an issue in the RFC, we can still change while in Preview |
Member
|
@anmenaga Please be sure to use squash and merge unless there is a good reason. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
POSIX shells have a
-lswitch to indicate it is a login shell which will process profiles. However, PowerShell by default already loads the profile and requires-noprofileto explicitly not load it. To make pwsh compatible with other tools (like VSCode) that expects a-lswitch, the change is to add-loadprofilealiased as-lso that it doesn't complain about that switch which is a no-op since we load the profile by default.Also sorted the switches alphabetically in the code.
PR Context
Fix #3600
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.