Skip to content

Move warning message to EndProcessing for ExperimentalFeature cmdlets so it only shows up once #9385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 1 commit into from
Apr 23, 2019
Merged

Move warning message to EndProcessing for ExperimentalFeature cmdlets so it only shows up once #9385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...nagement.Automation/engine/ExperimentalFeature/EnableDisableExperimentalFeatureCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@ public class EnableDisableExperimentalFeatureCommandBase : PSCmdlet
/// </summary>
[Parameter]
public ConfigScope Scope { get; set; } = ConfigScope.CurrentUser;

/// <summary>
/// EndProcessing method.
/// </summary>
protected override void EndProcessing()
{
WriteWarning(ExperimentalFeatureStrings.ExperimentalFeaturePending);
}
}

/// <summary>
Expand Down Expand Up @@ -87,8 +95,6 @@ internal static void UpdateConfig(PSCmdlet cmdlet, string[] name, ConfigScope sc
cmdlet.WriteError(new ErrorRecord(new ItemNotFoundException(errMsg), "ItemNotFoundException", ErrorCategory.ObjectNotFound, name));
return;
}

cmdlet.WriteWarning(ExperimentalFeatureStrings.ExperimentalFeaturePending);
}
}

Expand Down
10 changes: 10 additions & 0 deletions test/powershell/engine/ExperimentalFeature/EnableDisable-ExperimentalFeature.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,4 +94,14 @@ Describe "Enable-ExperimentalFeature and Disable-ExperimentalFeature tests" -tag
& $cmdlet ExpTest.FeatureOne -WarningVariable warning -WarningAction SilentlyContinue
$warning | Should -Not -BeNullOrEmpty -Because "A warning message is always given indicating restart is required"
}

It "Multiple features enabled will only output one warning message for <cmdlet>" -TestCases @(
@{ cmdlet = "Enable-ExperimentalFeature" },
@{ cmdlet = "Disable-Experimentalfeature" }
) {
param ($cmdlet)

Get-ExperimentalFeature | & $cmdlet -WarningAction SilentlyContinue -WarningVariable warning
$warning | Should -HaveCount 1
}
}