Add Preview assets for msix #9375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested review from
PaulHigin,
anmenaga and
daxian-dbw
as code owners
Collaborator
|
@SteveL-MSFT, your last commit had 1 failures in Expected $true, but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Api\TaskBasedAsyncPowerShellAPI.Tests.ps1: line 213
213: $ir.IsFaulted | Should -Be $true |
anmenaga
approved these changes
Apr 16, 2019
adityapatwardhan
approved these changes
Apr 16, 2019
Member
|
@PoshChan please retry windows |
Collaborator
|
@adityapatwardhan, successfully started retry of |
TravisEz13
approved these changes
Apr 16, 2019
adityapatwardhan
added
the
CL-BuildPackaging
TravisEz13
added a commit
that referenced
this pull request
Apr 27, 2019
* return correct casing of filesystem path during normalization * handle UNC case * handle case to add trailing separator back * add support for NTFS streams syntax * add case-sensitive test * only apply correct casing to directories * handle 8.3 path syntax * fix short path processing * Remove elements which do not work on earlier version on Windows PowerShell (#9411) * Use `Environment.NewLine` for new lines in `ConsoleHost` code (#9392) * Run CodeFormatter for Eventing (#9394) * Run CodeFormatter for MarkdownRender (#9398) * Run CodeFormatter for Security module (#9399) * Run CodeFormatter for WSMan.Runtime (#9401) * Run CodeFormatter for WSMan.Management (#9400) * Allow CI to run on branches with this name pattern: feature* (#9415) * Run CodeFormatter with BraceNewLine,UsingLocation,FormatDocument,NewLineAbove rules (#9393) * Build(deps): Bump NJsonSchema from 9.13.30 to 9.13.34 (#9421) * Build(deps): Bump NJsonSchema from 9.13.34 to 9.13.35 (#9429) Bumps [NJsonSchema](https://github.com/rsuter/NJsonSchema) from 9.13.34 to 9.13.35. - [Release notes](https://github.com/rsuter/NJsonSchema/releases) - [Commits](https://github.com/rsuter/NJsonSchema/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Build(deps): Bump Newtonsoft.Json (#9431) Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.1 to 12.0.2. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@12.0.1...12.0.2) Signed-off-by: dependabot[bot] <support@dependabot.com> * Build(deps): Bump Newtonsoft.Json from 12.0.1 to 12.0.2 (#9434) Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.1 to 12.0.2. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@12.0.1...12.0.2) Signed-off-by: dependabot[bot] <support@dependabot.com> * Add Preview assets for msix (#9375) * Adding tests for `Remove-Module` (#9276) * Build(deps): Bump gulp from 4.0.0 to 4.0.1 in /test/common/markdown (#9441) * Move warning message to EndProcessing so it only shows up once (#9385) * Run Codeformatter for SMA (#9402) * Fix the failed test and update 'Publish-TestResults' to make AzDO fail the task when any tests failed (#9457) * Enable building on Kali Linux (#9471) * Build test packages for windows, linux-x64, linux-arm, linux-arm64 and macOS (#9476) * Build(deps): Bump NJsonSchema from 9.13.35 to 9.13.36 (#9478) * Update Release_Process.md Add item for global tool Co-authored-by: Steve Lee <slee@microsoft.com> Co-authored-by: Steve Lee (POWERSHELL) <slee@ntdev.microsoft.com> Co-authored-by: Aditya Patwardhan <adityap@microsoft.com> Co-authored-by: Ilya <darpa@yandex.ru> Co-authored-by: Dongbo Wang <dongbow@microsoft.com> Co-authored-by: null <dependabot[bot]@users.noreply.github.com> Co-authored-by: pougetat <thomas.pouget-abadie@ensimag.grenoble-inp.fr> Co-authored-by: Andrew <anmenaga@microsoft.com>
TravisEz13
pushed a commit
that referenced
this pull request
May 13, 2019
# Conflicts: # tools/packaging/packaging.psm1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add Preview assets for icons/logo to msix package when building Preview package.
PR Context
The
New-MSIXPackagewas previously hardcoded to use Stable icon/logo assets. So when building a Preview package, it would have the Stable icon/logo, but the executable had the embedded Preview icon causing some confusion. Fix is to have equivalent assets used by msix package for Preview and use those if building a Preview package.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.