Skip to content

Fix Get-ChildItem -Path with wildcard char #9257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 4 commits into from
May 31, 2019
Merged

Fix Get-ChildItem -Path with wildcard char #9257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27f2011
[Feature] Fix Get-ChildItem -Path with wildcard char
kwkam Jul 30, 2018
4fa79fe
Use HaveCount in test
kwkam May 13, 2019
3df1a22
Update test
kwkam May 14, 2019
fc09190
Move test into new Describe block
kwkam May 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/System.Management.Automation/engine/SessionStateContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1477,7 +1477,7 @@ internal void GetChildItems(
string originalPath = path;
path =
Globber.GetProviderPath(
path,
context.SuppressWildcardExpansion ? path : WildcardPattern.Unescape(path),
context,
out provider,
out drive);
Expand Down Expand Up @@ -2441,7 +2441,7 @@ internal void GetChildNames(

string providerPath =
Globber.GetProviderPath(
path,
context.SuppressWildcardExpansion ? path : WildcardPattern.Unescape(path),
context,
out provider,
out drive);
Expand Down
16 changes: 16 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Get-ChildItem.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,22 @@ Describe "Get-ChildItem" -Tags "CI" {
}
}

Describe "Get-ChildItem with special path" -Tags "CI" {

BeforeAll {
$bracketDirName = "Test[Dir]"
$bracketDir = "Test``[Dir``]"
$bracketPath = Join-Path $TestDrive $bracketDir
$null = New-Item -Path $TestDrive -Name $bracketDirName -ItemType Directory -Force
}

It "Should list files in directory with name containing bracket char" {
$null = New-Item -Path $bracketPath -Name file1.txt -ItemType File
$null = New-Item -Path $bracketPath -Name file2.txt -ItemType File
Get-ChildItem -Path $bracketPath | Should -HaveCount 2
}
}

Describe 'FileSystem Provider Formatting' -Tag "CI","RequireAdminOnWindows" {

BeforeAll {
Expand Down