Skip to content

Fix coding style for NewModuleManifestCommand #9134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Mar 26, 2019
Merged

Fix coding style for NewModuleManifestCommand #9134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac7fc73
Fix coding style for NewModuleManifestCommand
throwaway774 Mar 14, 2019
f2f81cf
Addressing PR comments
throwaway774 Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 39 additions & 39 deletions src/System.Management.Automation/engine/Modules/NewModuleManifestCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ namespace Microsoft.PowerShell.Commands
public sealed class NewModuleManifestCommand : PSCmdlet
{
/// <summary>
/// The output path for the generated file...
/// Gets or sets the output path for the generated file.
/// </summary>
[Parameter(Mandatory = true, Position = 0)]
public string Path
Expand All @@ -43,7 +43,7 @@ public string Path
private string _path;

/// <summary>
/// Sets the list of files to load by default...
/// Gets or sets the list of files to load by default.
/// </summary>
[Parameter]
[AllowEmptyCollection]
Expand All @@ -58,7 +58,7 @@ public object[] NestedModules
private object[] _nestedModules;

/// <summary>
/// Set the GUID in the manifest file.
/// Gets or sets the GUID in the manifest file.
/// </summary>
[Parameter]
public Guid Guid
Expand All @@ -71,7 +71,7 @@ public Guid Guid
private Guid _guid = Guid.NewGuid();

/// <summary>
/// Set the author string in the manifest.
/// Gets or sets the author string in the manifest.
/// </summary>
[Parameter]
[AllowEmptyString]
Expand All @@ -85,7 +85,7 @@ public string Author
private string _author;

/// <summary>
/// Set the company name in the manifest.
/// Gets or sets the company name in the manifest.
/// </summary>
[Parameter]
[AllowEmptyString]
Expand All @@ -99,7 +99,7 @@ public string CompanyName
private string _companyName = string.Empty;

/// <summary>
/// Set the copyright string in the module manifest.
/// Gets or sets the copyright string in the module manifest.
/// </summary>
[Parameter]
[AllowEmptyString]
Expand All @@ -113,7 +113,7 @@ public string Copyright
private string _copyright;

/// <summary>
/// Set the module version...
/// Gets or sets the root module.
/// </summary>
[Parameter]
[AllowEmptyString]
Expand All @@ -128,7 +128,7 @@ public string RootModule
private string _rootModule = null;

/// <summary>
/// Set the module version...
/// Gets or sets the module version.
/// </summary>
[Parameter]
[ValidateNotNull]
Expand All @@ -142,7 +142,7 @@ public Version ModuleVersion
private Version _moduleVersion = new Version(0, 0, 1);

/// <summary>
/// Set the module description.
/// Gets or sets the module description.
/// </summary>
[Parameter]
[AllowEmptyString]
Expand All @@ -156,7 +156,7 @@ public string Description
private string _description;

/// <summary>
/// Set the ProcessorArchitecture required by this module.
/// Gets or sets the ProcessorArchitecture required by this module.
/// </summary>
[Parameter]
public ProcessorArchitecture ProcessorArchitecture
Expand All @@ -169,7 +169,7 @@ public ProcessorArchitecture ProcessorArchitecture
private ProcessorArchitecture? _processorArchitecture = null;

/// <summary>
/// Set the PowerShell version required by this module.
/// Gets or sets the PowerShell version required by this module.
/// </summary>
[Parameter]
public Version PowerShellVersion
Expand All @@ -182,10 +182,10 @@ public Version PowerShellVersion
private Version _powerShellVersion = null;

/// <summary>
/// Set the CLR version required by the module.
/// Gets or sets the CLR version required by the module.
/// </summary>
[Parameter]
public Version ClrVersion
public Version CLRVersion
{
get { return _ClrVersion; }

Expand All @@ -195,7 +195,7 @@ public Version ClrVersion
private Version _ClrVersion = null;

/// <summary>
/// Set the version of .NET Framework required by the module.
/// Gets or sets the version of .NET Framework required by the module.
/// </summary>
[Parameter]
public Version DotNetFrameworkVersion
Expand All @@ -208,7 +208,7 @@ public Version DotNetFrameworkVersion
private Version _DotNetFrameworkVersion = null;

/// <summary>
/// Set the name of PowerShell host required by the module.
/// Gets or sets the name of PowerShell host required by the module.
/// </summary>
[Parameter]
public string PowerShellHostName
Expand All @@ -221,7 +221,7 @@ public string PowerShellHostName
private string _PowerShellHostName = null;

/// <summary>
/// Set the version of PowerShell host required by the module.
/// Gets or sets the version of PowerShell host required by the module.
/// </summary>
[Parameter]
public Version PowerShellHostVersion
Expand All @@ -234,7 +234,7 @@ public Version PowerShellHostVersion
private Version _PowerShellHostVersion = null;

/// <summary>
/// Sets the list of Dependencies for the module.
/// Gets or sets the list of Dependencies for the module.
/// </summary>
[Parameter]
[ArgumentTypeConverter(typeof(ModuleSpecification[]))]
Expand All @@ -250,7 +250,7 @@ public object[] RequiredModules
private object[] _requiredModules;

/// <summary>
/// Sets the list of types files for the module.
/// Gets or sets the list of types files for the module.
/// </summary>
[Parameter]
[AllowEmptyCollection]
Expand All @@ -266,7 +266,7 @@ public string[] TypesToProcess
private string[] _types;

/// <summary>
/// Sets the list of formats files for the module.
/// Gets or sets the list of formats files for the module.
/// </summary>
[Parameter]
[AllowEmptyCollection]
Expand All @@ -282,7 +282,7 @@ public string[] FormatsToProcess
private string[] _formats;

/// <summary>
/// Sets the list of ps1 scripts to run in the session state of the import-module invocation.
/// Gets or sets the list of ps1 scripts to run in the session state of the import-module invocation.
/// </summary>
[Parameter]
[AllowEmptyCollection]
Expand All @@ -298,7 +298,7 @@ public string[] ScriptsToProcess
private string[] _scripts;

/// <summary>
/// Set the list of assemblies to load for this module.
/// Gets or sets the list of assemblies to load for this module.
/// </summary>
[Parameter]
[AllowEmptyCollection]
Expand All @@ -314,7 +314,7 @@ public string[] RequiredAssemblies
private string[] _requiredAssemblies;

/// <summary>
/// Specify any additional files used by this module.
/// Gets or sets the additional files used by this module.
/// </summary>
[Parameter]
[AllowEmptyCollection]
Expand All @@ -330,7 +330,7 @@ public string[] FileList
private string[] _miscFiles;

/// <summary>
/// List of other modules included with this module.
/// Gets or sets the list of other modules included with this module.
/// Like the RequiredModules key, this list can be a simple list of module names or a complex list of module hashtables.
/// </summary>
[Parameter]
Expand All @@ -348,7 +348,7 @@ public object[] ModuleList
private object[] _moduleList;

/// <summary>
/// Specify any functions to export from this manifest.
/// Gets or sets the functions to export from this manifest.
/// </summary>
[Parameter]
[AllowEmptyCollection]
Expand All @@ -364,7 +364,7 @@ public string[] FunctionsToExport
private string[] _exportedFunctions;

/// <summary>
/// Specify any aliases to export from this manifest.
/// Gets or sets the aliases to export from this manifest.
/// </summary>
[Parameter]
[AllowEmptyCollection]
Expand All @@ -380,7 +380,7 @@ public string[] AliasesToExport
private string[] _exportedAliases;

/// <summary>
/// Specify any variables to export from this manifest.
/// Gets or sets the variables to export from this manifest.
/// </summary>
[Parameter]
[AllowEmptyCollection]
Expand All @@ -396,7 +396,7 @@ public string[] VariablesToExport
private string[] _exportedVariables = new string[] { "*" };

/// <summary>
/// Specify any cmdlets to export from this manifest.
/// Gets or sets the cmdlets to export from this manifest.
/// </summary>
[Parameter]
[AllowEmptyCollection]
Expand All @@ -412,7 +412,7 @@ public string[] CmdletsToExport
private string[] _exportedCmdlets;

/// <summary>
/// Specify any dsc resources to export from this manifest.
/// Gets or sets the dsc resources to export from this manifest.
/// </summary>
[Parameter]
[AllowEmptyCollection]
Expand All @@ -428,7 +428,7 @@ public string[] DscResourcesToExport
private string[] _dscResourcesToExport;

/// <summary>
/// Specify compatible PSEditions of this module.
/// Gets or sets the compatible PSEditions of this module.
/// </summary>
[Parameter]
[AllowEmptyCollection]
Expand All @@ -445,7 +445,7 @@ public string[] CompatiblePSEditions
private string[] _compatiblePSEditions;

/// <summary>
/// Specify any module-specific private data here.
/// Gets or sets the module-specific private data here.
/// </summary>
[Parameter(Mandatory = false)]
[AllowNull]
Expand All @@ -459,7 +459,7 @@ public object PrivateData
private object _privateData;

/// <summary>
/// Specify any Tags.
/// Gets or sets the Tags.
/// </summary>
[Parameter(Mandatory = false)]
[ValidateNotNullOrEmpty]
Expand All @@ -468,28 +468,28 @@ public object PrivateData
public string[] Tags { get; set; }

/// <summary>
/// Specify the ProjectUri.
/// Gets or sets the ProjectUri.
/// </summary>
[Parameter(Mandatory = false)]
[ValidateNotNullOrEmpty]
public Uri ProjectUri { get; set; }

/// <summary>
/// Specify the LicenseUri.
/// Gets or sets the LicenseUri.
/// </summary>
[Parameter(Mandatory = false)]
[ValidateNotNullOrEmpty]
public Uri LicenseUri { get; set; }

/// <summary>
/// Specify the IconUri.
/// Gets or sets the IconUri.
/// </summary>
[Parameter(Mandatory = false)]
[ValidateNotNullOrEmpty]
public Uri IconUri { get; set; }

/// <summary>
/// Specify the ReleaseNotes.
/// Gets or sets the ReleaseNotes.
/// </summary>
[Parameter(Mandatory = false)]
[ValidateNotNullOrEmpty]
Expand All @@ -516,7 +516,7 @@ public object PrivateData
public string[] ExternalModuleDependencies { get; set; }

/// <summary>
/// Specify the HelpInfo URI.
/// Gets or sets the HelpInfo URI.
/// </summary>
[Parameter]
[AllowNull]
Expand All @@ -531,7 +531,7 @@ public string HelpInfoUri
private string _helpInfoUri;

/// <summary>
/// This parameter causes the module manifest string to be to the output stream...
/// Gets or sets whether the module manifest string should go to the output stream.
/// </summary>
[Parameter]
public SwitchParameter PassThru
Expand All @@ -544,7 +544,7 @@ public SwitchParameter PassThru
private bool _passThru;

/// <summary>
/// Specify the Default Command Prefix.
/// Gets or sets the Default Command Prefix.
/// </summary>
[Parameter]
[AllowNull]
Expand Down Expand Up @@ -1088,7 +1088,7 @@ protected override void EndProcessing()

BuildModuleManifest(result, nameof(DotNetFrameworkVersion), StringUtil.Format(Modules.DotNetFrameworkVersion, Modules.PrerequisiteForDesktopEditionOnly), _DotNetFrameworkVersion != null && !string.IsNullOrEmpty(_DotNetFrameworkVersion.ToString()), () => QuoteName(_DotNetFrameworkVersion), streamWriter);

BuildModuleManifest(result, nameof(Modules.CLRVersion), StringUtil.Format(Modules.CLRVersion, Modules.PrerequisiteForDesktopEditionOnly), _ClrVersion != null && !string.IsNullOrEmpty(_ClrVersion.ToString()), () => QuoteName(_ClrVersion), streamWriter);
BuildModuleManifest(result, nameof(CLRVersion), StringUtil.Format(Modules.CLRVersion, Modules.PrerequisiteForDesktopEditionOnly), _ClrVersion != null && !string.IsNullOrEmpty(_ClrVersion.ToString()), () => QuoteName(_ClrVersion), streamWriter);

BuildModuleManifest(result, nameof(ProcessorArchitecture), Modules.ProcessorArchitecture, _processorArchitecture.HasValue, () => QuoteName(_processorArchitecture.ToString()), streamWriter);

Expand Down