Fix coding style for NewModuleManifestCommand #9134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
reviewed
Mar 23, 2019
| /// </summary> | ||
| [Parameter] | ||
| public Guid Guid | ||
| public Guid GUID |
Collaborator
There was a problem hiding this comment.
Please revert - we should use camel style. Also it is public API (breaking change).
| [AllowNull] | ||
| [SuppressMessage("Microsoft.Design", "CA1056:UriPropertiesShouldNotBeStrings")] | ||
| public string HelpInfoUri | ||
| public string HelpInfoURI |
Collaborator
There was a problem hiding this comment.
Please revert - it is public API (breaking change).
| public Guid Guid | ||
| public Guid GUID | ||
| { | ||
| get { return _guid; } |
Collaborator
There was a problem hiding this comment.
@pougetat You could review all such unneeded private fields and remove them. Better in follow PR.
iSazonov
added
the
CL-CodeCleanup
iSazonov
approved these changes
Mar 26, 2019
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to fix some of the coding style in NewModuleManifestCommand
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests