The original name makes more sense. Please revert.

Why first condition is <= but second one <?

GetRandomDouble returns a random number between minValue (included) and maxValue (excluded). Hence the presence of the do{}while(randomNumber >= maxValue) loop

The same.

For this case I'm not too sure.
At line 347 it will try to enforce maxValue as an excluding upper bound due to the Next(min, max) method but in this scenario I'm not sure if it will enforce maxValue as an exclusive upper bound.
In doubt I think it's best to at least stick with previous behavior in which the Assert came after the function call thus trying to enforce maxValue as an excluded upper bound in all cases. It's safer to have a script fail than to have it run with an unexpected value.
@PaulHigin ?

I'd expect the same behavior (included or excluded) for both low and high boundaries.
Although we can guarantee this only for integers.

In that case :

• do you consider this resolved ?
• do you want different groups of debug.assert statements for each of the two scenarios I listed where each assert correctly follows what the generator should return as a value ?
• do you want a single debug.assert group which would be this one but with randomValue <= upper bound ?
• do you want @PaulHigin 's take on this ?

😄

@pougetat Please remove all controversial changes from this PR so that we can move forward

ok ill put the debug.assert statements back where they were.

The original names makes more sense. Please revert.