Skip to content

Remove AppImage from tools - #9100

Merged
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
Geweldig:remove_appimage_install
Mar 11, 2019
Merged

Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
Geweldig:remove_appimage_install

Conversation

@Geweldig

Copy link
Copy Markdown
Contributor

PR Summary

  • Remove the possibility to install via AppImage and generate an AppImage.
  • Add missing install dependency to README

PR Context

As discussed in #9071, it was determined that AppImage was no longer used, and should be removed from the install scripts.

PR Checklist

@Geweldig

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) as discussed on #9071

@RDIL Reece Dunham (RDIL) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is likely that this won’t get looked over until Monday.

@Geweldig

Copy link
Copy Markdown
Contributor Author

Which should be fine, as this isn't an extremely high priority change!

@adityapatwardhan

Copy link
Copy Markdown
Member

Pushed an empty commit with [Package] to trigger packaging code.

@adityapatwardhan

Copy link
Copy Markdown
Member

Pushed [Feature] tag due to #9121

@daxian-dbw Dongbo Wang (daxian-dbw) added this to the 6.2.0 milestone Mar 11, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit b115dff into PowerShell:master Mar 11, 2019
@adityapatwardhan

Copy link
Copy Markdown
Member

Bram Crielaard (@Geweldig) Thank you for your contribution!

@Geweldig

Copy link
Copy Markdown
Contributor Author

Not a problem, PowerShell is a fun project to work on!

@Geweldig
Bram Crielaard (Geweldig) deleted the remove_appimage_install branch March 12, 2019 07:53
@TravisEz13 Travis Plunk (TravisEz13) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Mar 29, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants