Remove AppImage from tools #9100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geweldig
requested review from
PaulHigin,
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
Contributor
Author
|
@TravisEz13 as discussed on #9071 |
RDIL
approved these changes
Mar 9, 2019
Contributor
RDIL
left a comment
RDIL
left a comment
There was a problem hiding this comment.
LGTM. It is likely that this won’t get looked over until Monday.
Contributor
Author
|
Which should be fine, as this isn't an extremely high priority change! |
TravisEz13
approved these changes
Mar 11, 2019
adityapatwardhan
approved these changes
Mar 11, 2019
Member
|
Pushed an empty commit with |
1 task
Member
|
Pushed |
Member
|
@Geweldig Thank you for your contribution! |
Contributor
Author
|
Not a problem, PowerShell is a fun project to work on! |
TravisEz13
added
the
CL-CodeCleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
As discussed in #9071, it was determined that AppImage was no longer used, and should be removed from the install scripts.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests