Made -Subject parameter of sendMail command no longer mandatory. #8961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ece-jacob-scott
requested review from
JamesWTruher and
PaulHigin
as code owners
Member
|
This is a student at HackIllinois. @rjmholt and I are working with the students here and are reviewing PRs that they send. |
iSazonov
reviewed
Feb 24, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/Send-MailMessage.Tests.ps1
Outdated
Show resolved
Hide resolved
Collaborator
|
@adityapatwardhan Can we merge or will wait #8859? |
Member
There was a problem hiding this comment.
You can delete this line I think
Collaborator
|
@ece-jacob-scott @TylerLeonhardt Could you continue and rebase to get latest tests? |
Member
|
@ece-jacob-scott is a master at rebasing now :) but if you need help feel free to ping me |
Collaborator
|
Please rebase so we could merge. |
ece-jacob-scott
requested review from
BrucePay,
Francisco-Gamino,
SteveL-MSFT,
TravisEz13,
adityapatwardhan,
anmenaga,
daxian-dbw,
joeyaiello and
mirichmo
as code owners
ece-jacob-scott
force-pushed
the
no-subject-fix
branch
from
23ac05a to
2d1482d
Compare
iSazonov
approved these changes
Mar 17, 2019
iSazonov
added
the
CL-General
Collaborator
|
@ece-jacob-scott Thanks for your contribution! |
Member
|
Wahoo! Well done! 🎉 |
Collaborator
|
Ah, sorry - please create new issue in PowerShell-Docs repo and add reference in the PR description. |
iSazonov
added
the
Documentation Needed in this repo
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4043
The PR just makes the subject parameter for the sendMail command able to be null. It also adds a test for the send mail function to be called with no subject parameter.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests