Skip to content

Conversation

@bergmeister
Copy link
Contributor

@bergmeister bergmeister commented Feb 20, 2019

PR Summary

WIP only because we wait for the deployment rollout of this feature to reach everyone.
Encourage the usage of the new GitHub draft PR feature over WIP since the new feature will make WIP redundant soon. https://github.blog/2019-02-14-introducing-draft-pull-requests/
Unfortunately one cannot convert existing PRs to drafts at the moment but once the existing WIP PRs are merged, I propose to remove the WIP GitHub app.

PR Context

PR Checklist

@bergmeister bergmeister marked this pull request as ready for review February 20, 2019 06:56
@markekraus
Copy link
Contributor

markekraus commented Feb 20, 2019

Should link to the help docs instead of the announcement blog? https://help.github.com/articles/about-pull-requests/#draft-pull-requests

@bergmeister
Copy link
Contributor Author

bergmeister commented Feb 20, 2019

Yes, good idea, thanks. I changed it to that

@TravisEz13
Copy link
Member

Our org doesn't support PR drafts and GitHub says they don't plan on supporting them. I've asked GitHub to update the documentation.

@vexx32
Copy link
Collaborator

vexx32 commented Feb 20, 2019

Could you elaborate, @TravisEz13?

It sounds like you're saying there's a requirement for them to be allowed, but GH have mentioned nothing of the sort that I've been able to find.

Additionally, it appears @TylerLeonhardt was able to submit a draft PR (#8923) to this repo?

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Feb 20, 2019

We should wait like a month or 2 before getting this in. I just got Draft PRs yesterday.

Or perhaps, @bergmeister you should call out that "if you don't have this capability yet, put "WIP" in the title

@bergmeister
Copy link
Contributor Author

bergmeister commented Feb 20, 2019

I also only got it today, we can definitely wait until the feature has fully rolled out (I was under the impression that the rollout is on a per repository rather than a per user basis, can anyone confirm that?).
Since they haven't implemented the feature to change a published PR back to a draft, I'll put the good ol' WIP tag on again

@bergmeister bergmeister changed the title Update PR template to inform about using Drafts instead of WIP WIP Update PR template to inform about using Drafts instead of WIP Feb 20, 2019
@TylerLeonhardt
Copy link
Member

I just hope it wont be as slow as the GitHub Actions rollout 😶

@TylerLeonhardt
Copy link
Member

Sends PR to inform about using Drafts instead of WIP

Uses WIP

😛

@TravisEz13
Copy link
Member

GitHub is saying that they won't be supporting organizations that are paying on old billing plans and that you must upgrade to a new billing plan to use the feature.

@TravisEz13
Copy link
Member

Although, I just looked and it seems they changed their mind and didn't email me.

@bergmeister
Copy link
Contributor Author

bergmeister commented Feb 21, 2019

Well, I am on the free plan and have actually submitted this PR initially as a draft just to get a feeling for myself how it looks like before I published it.
image
The docs here say:
image

…o patch-7

# Conflicts:
#	.github/PULL_REQUEST_TEMPLATE.md
@TravisEz13
Copy link
Member

TravisEz13 commented Feb 21, 2019

I emailed back and asked for clarification, but I think we can assume that they decided excluding older billing plans was a bad idea.

And they are talking about the PowerShell organization's billing plan, not the plan of the user submitting the PR.

@iSazonov
Copy link
Collaborator

Currently we can put WIP and remove it in any time. Does the Draft feature support switching to draft and reverse in any time?

@TylerLeonhardt
Copy link
Member

That's a good question. I don't see anything about going from PR -> Draft PR

@TravisEz13
Copy link
Member

TravisEz13 commented Mar 1, 2019

No... Once a Draft PR becomes a real PR you cannot make it a Draft PR. And a PR created as a real PR, cannot be made a draft.

I would recommend contacting GitHub support and giving this feedback.

@iSazonov
Copy link
Collaborator

iSazonov commented Mar 1, 2019

@TravisEz13 I sent the feedback to GitHub.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it's been rolled out to pretty much everyone... so I'm good with this.

@bergmeister
Copy link
Contributor Author

Should we leave some info about 'use WIP for going back to draft state' or just ask the author to do so in special cases?

@iSazonov
Copy link
Collaborator

iSazonov commented Mar 1, 2019

I suggest to continue using WIP until we get full-featured Draft.

@vexx32
Copy link
Collaborator

vexx32 commented Mar 1, 2019

If it's available we may as well make use of it, and just use WIP alongside until Drafts get more features.

@stale
Copy link

stale bot commented Mar 31, 2019

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Mar 31, 2019
@TylerLeonhardt
Copy link
Member

@SteveL-MSFT you should probably give an opinion here.

@stale stale bot removed the Stale label Mar 31, 2019
@TravisEz13
Copy link
Member

Drafts have the advantage that people aren't notified to review. I think we should suggest people use drafts, and use WIP only to move back to a similar state.

@SteveL-MSFT
Copy link
Member

I think it's fine to have both Draft and WIP co-existing for now. Once we see that Drafts are working as a replacement for WIP, we can consider removing WIP support.

@stale
Copy link

stale bot commented May 5, 2019

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label May 5, 2019
@stale
Copy link

stale bot commented May 15, 2019

This PR has been automatically closed because it is stale. If you wish to continue working on the PR, please first update the PR, then reopen it.
Thanks again for your contribution.
Community members are welcome to grab these works.

@stale stale bot closed this May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants