-
Notifications
You must be signed in to change notification settings - Fork 8.1k
WIP Update PR template to inform about using Drafts instead of WIP #8922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Should link to the help docs instead of the announcement blog? https://help.github.com/articles/about-pull-requests/#draft-pull-requests |
|
Yes, good idea, thanks. I changed it to that |
|
Our org doesn't support PR drafts and GitHub says they don't plan on supporting them. I've asked GitHub to update the documentation. |
|
Could you elaborate, @TravisEz13? It sounds like you're saying there's a requirement for them to be allowed, but GH have mentioned nothing of the sort that I've been able to find. Additionally, it appears @TylerLeonhardt was able to submit a draft PR (#8923) to this repo? |
|
We should wait like a month or 2 before getting this in. I just got Draft PRs yesterday. Or perhaps, @bergmeister you should call out that "if you don't have this capability yet, put "WIP" in the title |
|
I also only got it today, we can definitely wait until the feature has fully rolled out (I was under the impression that the rollout is on a per repository rather than a per user basis, can anyone confirm that?). |
|
I just hope it wont be as slow as the GitHub Actions rollout 😶 |
😛 |
|
GitHub is saying that they won't be supporting organizations that are paying on old billing plans and that you must upgrade to a new billing plan to use the feature. |
|
Although, I just looked and it seems they changed their mind and didn't email me. |
|
Well, I am on the free plan and have actually submitted this PR initially as a draft just to get a feeling for myself how it looks like before I published it. |
…o patch-7 # Conflicts: # .github/PULL_REQUEST_TEMPLATE.md
|
I emailed back and asked for clarification, but I think we can assume that they decided excluding older billing plans was a bad idea. And they are talking about the |
|
Currently we can put WIP and remove it in any time. Does the Draft feature support switching to draft and reverse in any time? |
|
That's a good question. I don't see anything about going from PR -> Draft PR |
|
No... Once a Draft PR becomes a real PR you cannot make it a Draft PR. And a PR created as a real PR, cannot be made a draft. I would recommend contacting GitHub support and giving this feedback. |
|
@TravisEz13 I sent the feedback to GitHub. |
TylerLeonhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like it's been rolled out to pretty much everyone... so I'm good with this.
|
Should we leave some info about 'use WIP for going back to draft state' or just ask the author to do so in special cases? |
|
I suggest to continue using WIP until we get full-featured Draft. |
|
If it's available we may as well make use of it, and just use WIP alongside until Drafts get more features. |
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
|
@SteveL-MSFT you should probably give an opinion here. |
|
Drafts have the advantage that people aren't notified to review. I think we should suggest people use drafts, and use WIP only to move back to a similar state. |
|
I think it's fine to have both Draft and WIP co-existing for now. Once we see that Drafts are working as a replacement for WIP, we can consider removing WIP support. |
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
|
This PR has been automatically closed because it is stale. If you wish to continue working on the PR, please first update the PR, then reopen it. |


PR Summary
WIP only because we wait for the deployment rollout of this feature to reach everyone.
Encourage the usage of the new GitHub draft PR feature over WIP since the new feature will make WIP redundant soon. https://github.blog/2019-02-14-introducing-draft-pull-requests/
Unfortunately one cannot convert existing PRs to drafts at the moment but once the existing WIP PRs are merged, I propose to remove the WIP GitHub app.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests