Skip to content

Reduce string allocations when formatting file system objects. #8831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 3 commits into from
Feb 7, 2019
Merged

Reduce string allocations when formatting file system objects. #8831

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1509da0
Reduce string allocations when formatting file system objects.
powercode Feb 5, 2019
4874053
Clear cache FullName when the module changes.
powercode Feb 6, 2019
9e68f73
Removing comment
powercode Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 27 additions & 19 deletions src/System.Management.Automation/engine/DataStoreAdapterProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ public class ProviderInfo
/// </summary>
private SessionState _sessionState;

private string _fullName;

/// <summary>
/// Gets the name of the provider.
/// </summary>
Expand All @@ -47,29 +49,34 @@ internal string FullName
{
get
{
string result = this.Name;
if (!string.IsNullOrEmpty(this.PSSnapInName))
string GetFullName(string name, string psSnapInName, string moduleName)
{
result =
string.Format(
System.Globalization.CultureInfo.InvariantCulture,
"{0}\\{1}",
this.PSSnapInName,
this.Name);
}
string result = name;
if (!string.IsNullOrEmpty(psSnapInName))
{
result =
string.Format(
System.Globalization.CultureInfo.InvariantCulture,
"{0}\\{1}",
psSnapInName,
name);
}

// After converting core snapins to load as modules, the providers will have Module property populated
else if (!string.IsNullOrEmpty(this.ModuleName))
{
result =
string.Format(
System.Globalization.CultureInfo.InvariantCulture,
"{0}\\{1}",
this.ModuleName,
this.Name);
// After converting core snapins to load as modules, the providers will have Module property populated
else if (!string.IsNullOrEmpty(moduleName))
{
result =
string.Format(
System.Globalization.CultureInfo.InvariantCulture,
"{0}\\{1}",
moduleName,
name);
}

return result;
}

return result;
return _fullName ?? (_fullName = GetFullName(Name, PSSnapInName, ModuleName));
}
}

Expand Down Expand Up @@ -136,6 +143,7 @@ public string ModuleName
internal void SetModule(PSModuleInfo module)
{
Module = module;
_fullName = null;
}

/// <summary>
Expand Down