Refactor of travis.ps1 into ci.psm1
#8822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDIL
requested review from
PaulHigin,
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
RDIL
changed the title
travis.ps1travis.ps1 into ci.psm1
Contributor
Author
|
Oops uh I think I deleted the feature tests, I'll try to add them back |
RDIL
changed the title
travis.ps1 into ci.psm1travis.ps1 into ci.psm1
TravisEz13
reviewed
Feb 4, 2019
TravisEz13
requested changes
Feb 4, 2019
RDIL
changed the title
travis.ps1 into ci.psm1travis.ps1 into ci.psm1
Member
TravisEz13
reviewed
Feb 8, 2019
TravisEz13
reviewed
Feb 8, 2019
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
TravisEz13
reviewed
Feb 8, 2019
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
TravisEz13
reviewed
Feb 8, 2019
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
TravisEz13
reviewed
Feb 8, 2019
TravisEz13
reviewed
Feb 8, 2019
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
TravisEz13
reviewed
Feb 8, 2019
TravisEz13
reviewed
Feb 8, 2019
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
TravisEz13
reviewed
Feb 8, 2019
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
TravisEz13
reviewed
Feb 8, 2019
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
TravisEz13
reviewed
Feb 8, 2019
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
TravisEz13
approved these changes
Feb 8, 2019
Member
|
started a macOS and Linux daily build to verify merge |
11 tasks
Member
|
I found one issue, but I created a PR for it. |
TravisEz13
added a commit
that referenced
this pull request
Feb 9, 2019
Remove references to uninitialized variable regressed in #8822 ## PR Context Some artifacts never got published because the conditions would never be true
iSazonov
added
the
CL-Tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Refactors
travis.ps1. Important for maintainers: I removed the webhook and badge stuff as neither exist anymore. I also merged the build and test phase with the bootstrap phase.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests