Repository navigation
Change xUnit RunspaceTests to run sequentially - #8796
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
Conversation
|
If we turn off this test we will never fix the race condition which is very bad for real world scenarios. I suggest to review and merge #8779 that will eliminate inter-thread race conditions. Then we could think more about inter-process race conditions. I already look this and couldl push a PR. |
|
Paul Higinbotham (@PaulHigin) Could you look at the xUnit failure? |
|
Aditya Patwardhan (@adityapatwardhan) Ilya (@iSazonov) The tests are still failing (but in a different test), and in the same way (malformed file path). So I will re-enable the test and try running as sequential instead of parallel, to verify this is indeed a race condition. |
|
Not waiting the recommended 24 hours since this is blocking PRs. |
PR Summary
XUnit parallel runspace tests are failing with obscure errors. This appears to be due to parallelism and the tests appear to pass when run serially. This change is to convert the RunspaceTests to Sequential operation
PR Context
These tests have been failing fairly consistently if randomly in our daily builds, and appear to be due to running them in parallel.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests