Skip to content

Change xUnit RunspaceTests to run sequentially - #8796

Merged
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
PaulHigin:skip-parallel-runspacetest
Jan 30, 2019
Merged

Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
PaulHigin:skip-parallel-runspacetest

Conversation

@PaulHigin

@PaulHigin Paul Higinbotham (PaulHigin) commented Jan 30, 2019 •

Copy link
Copy Markdown
Contributor

PR Summary

XUnit parallel runspace tests are failing with obscure errors. This appears to be due to parallelism and the tests appear to pass when run serially. This change is to convert the RunspaceTests to Sequential operation

PR Context

These tests have been failing fairly consistently if randomly in our daily builds, and appear to be due to running them in parallel.

PR Checklist

@iSazonov

Copy link
Copy Markdown
Collaborator

If we turn off this test we will never fix the race condition which is very bad for real world scenarios. I suggest to review and merge #8779 that will eliminate inter-thread race conditions. Then we could think more about inter-process race conditions. I already look this and couldl push a PR.

@adityapatwardhan

Copy link
Copy Markdown
Member

Paul Higinbotham (@PaulHigin) Could you look at the xUnit failure?
Also put a description and context in the PR description

@PaulHigin

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) Ilya (@iSazonov) The tests are still failing (but in a different test), and in the same way (malformed file path). So I will re-enable the test and try running as sequential instead of parallel, to verify this is indeed a race condition.

@PaulHigin Paul Higinbotham (PaulHigin) changed the title Temporarily skipping randomly failing test WIP Temporarily skipping randomly failing test Jan 30, 2019
@PaulHigin Paul Higinbotham (PaulHigin) changed the title WIP Temporarily skipping randomly failing test Change xUnit RunspaceTests to run sequentially Jan 30, 2019
@adityapatwardhan

Copy link
Copy Markdown
Member

Not waiting the recommended 24 hours since this is blocking PRs.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit f3efcab into PowerShell:master Jan 30, 2019
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 30, 2019
@PaulHigin
Paul Higinbotham (PaulHigin) deleted the skip-parallel-runspacetest branch January 30, 2019 23:00
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants