Skip to content

Enable creating relative symlinks with New-Item #8783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 6 commits into from
Feb 7, 2019
Merged

Enable creating relative symlinks with New-Item #8783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
35ec717
[feature] enable creating relative symlinks
Jan 29, 2019
2b10201
[feature] remove unnecessary assignment of $testdrive in test
SteveL-MSFT Jan 31, 2019
2c7520a
[feature] disable test on non-Windows
SteveL-MSFT Feb 1, 2019
0a4411d
[feature] address Ilya's feedback
SteveL-MSFT Feb 4, 2019
1d6a15a
Update test/powershell/Modules/Microsoft.PowerShell.Management/New-It…
vexx32 Feb 5, 2019
9eb3fa0
Update src/System.Management.Automation/engine/SessionStateContainer.cs
iSazonov Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/System.Management.Automation/engine/SessionStateContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3535,7 +3535,12 @@ internal void NewItem(
throw PSTraceSource.NewInvalidOperationException(SessionStateStrings.PathNotFound, targetPath);
}

content = globbedTarget[0];
// If the original target was a relative path, we want to leave it as relative if it did not require
// globbing to resolve.
if (WildcardPattern.ContainsWildcardCharacters(targetPath))
{
content = globbedTarget[0];
}
}

NewItemPrivate(providerInstance, composedPath, type, content, context);
Expand Down
2 changes: 0 additions & 2 deletions test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,6 @@ Describe "Hard link and symbolic link tests" -Tags "CI", "RequireAdminOnWindows"

Context "Get-ChildItem and symbolic links" {
BeforeAll {
$TestDrive = "TestDrive:"
$alphaDir = Join-Path $TestDrive "sub-alpha"
$alphaLink = Join-Path $TestDrive "link-alpha"
$alphaFile1 = Join-Path $alphaDir "AlphaFile1.txt"
Expand Down Expand Up @@ -671,7 +670,6 @@ Describe "Copy-Item can avoid copying an item onto itself" -Tags "CI", "RequireA
# attempt is made to copy an item onto itself.
$selfCopyKey = "SelfCopy"

$TestDrive = "TestDrive:"
$subDir = "$TestDrive/sub"
$otherSubDir = "$TestDrive/other-sub"
$fileName = "file.txt"
Expand Down
12 changes: 12 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/New-Item.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,18 @@ Describe "New-Item with links" -Tags @('CI', 'RequireAdminOnWindows') {
$symbolicLinkPath = New-Item -ItemType SymbolicLink -Path "$tmpDirectory/$folderName/" -Value "/bar/"
$symbolicLinkPath | Should -Not -BeNullOrEmpty
}

It "New-Item -ItemType SymbolicLink should be able to create a relative link" -Skip:(!$IsWindows) {
try {
Push-Location $TestDrive
$relativeFilePath = Join-Path -Path . -ChildPath "relativefile.txt"
$file = New-Item -ItemType File -Path $relativeFilePath
$link = New-Item -ItemType SymbolicLink -Path ./link -Target $relativeFilePath
$link.Target | Should -BeExactly $relativeFilePath
} finally {
Pop-Location
}
}
}

Describe "New-Item with links fails for non elevated user if developer mode not enabled on Windows." -Tags "CI" {
Expand Down