Skip to content

Reduce race condition probability for config file access #8779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 5 commits into from
Mar 10, 2019
Merged

Reduce race condition probability for config file access #8779

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4254494
Reduce race condition probability for config file access
iSazonov Jan 29, 2019
1caaa7c
Revert TryEnterReadLock
iSazonov Feb 22, 2019
7381a1d
Revert TryEnterWriteLock
iSazonov Feb 22, 2019
3ddd12b
Revert default and retries
iSazonov Mar 7, 2019
fee0cbb
Revert comment and try-finally
iSazonov Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/PSConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ private void UpdateValueInFile<T>(ConfigScope scope, string key, T value, bool a
// prevents other processes from reading or writing the file while
// the update is in progress. It also locks out readers during write
// operations.
using (FileStream fs = new FileStream(fileName, FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.None))
using (FileStream fs = WaitForFile(fileName, FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.None))
{
JObject jsonObject = null;

Expand Down