Skip to content

Remove extra AppVeyor environment check #8709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 2 commits into from
Feb 8, 2019
Merged

Remove extra AppVeyor environment check #8709

TravisEz13 merged 2 commits into from
Feb 8, 2019

Conversation

@RDIL
Copy link
Contributor

@RDIL RDIL commented Jan 22, 2019 •
edited
Loading

PR Summary

Removes a check for AppVeyor env

PR Context

AppVeyor removed (#8686 extension)

PR Checklist

@RDIL RDIL changed the title Remove extra appveyor environment check Remove extra AppVeyor environment check Jan 22, 2019
bergmeister
bergmeister suggested changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@bergmeister bergmeister left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I realised only now that appveyor.yml is now completely gone. This change is ok

@iSazonov
Copy link
Collaborator

iSazonov commented Jan 23, 2019

Do we still use appveyor.psm1 ?

@RDIL
Copy link
Contributor Author

RDIL commented Jan 23, 2019 •
edited
Loading

@iSazonov Yeah, the Windows VSTS agent imports it. It could be renamed.

@RDIL
Copy link
Contributor Author

RDIL commented Jan 23, 2019

@iSazonov https://github.com/PowerShell/PowerShell/blob/master/.vsts-ci/windows.yml#L70

@iSazonov
Copy link
Collaborator

iSazonov commented Jan 23, 2019

Thanks. I see. Maybe need rename...

@RDIL
Copy link
Contributor Author

RDIL commented Jan 23, 2019

I can do that if you would like.

@iSazonov
Copy link
Collaborator

iSazonov commented Jan 23, 2019

Not in the PR and if @TravisEz13 agrees.

@RDIL
Copy link
Contributor Author

RDIL commented Jan 23, 2019

Alright, if Mr. Plunk gives his 👍 then I'll open a different PR for it.

TravisEz13
TravisEz13 reviewed Jan 24, 2019
View reviewed changes
@iSazonov
Copy link
Collaborator

iSazonov commented Feb 8, 2019

@TravisEz13 Could you please merge?

@TravisEz13 TravisEz13 merged commit 3ab7e2e into PowerShell:master Feb 8, 2019
@TravisEz13 TravisEz13 added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Feb 8, 2019
@RDIL RDIL deleted the patch-1 branch February 8, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@iSazonov iSazonov iSazonov approved these changes

+1 more reviewer

@bergmeister bergmeister bergmeister approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RDIL @iSazonov @bergmeister @TravisEz13