Skip to content

Remove appveyor environment checks #8669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 6 commits into from
Jan 17, 2019
Merged

Remove appveyor environment checks #8669

TravisEz13 merged 6 commits into from
Jan 17, 2019

Conversation

@RDIL
Copy link
Contributor

@RDIL RDIL commented Jan 16, 2019 •
edited
Loading

PR Summary

Remove check to see if the env is a CI AppVeyor build

PR Context

AppVeyor was removed

PR Checklist

daxian-dbw
daxian-dbw requested changes Jan 17, 2019
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add [feature] tag to your commit message after addressing the comment. The test you are change is a feature test, which only runs with the [feature] tag.

@RDIL RDIL changed the title Env can't be appveyor anymore [feature] Env can't be appveyor anymore Jan 17, 2019
@iSazonov
Copy link
Collaborator

iSazonov commented Jan 17, 2019

@RDIL Please reword the PR title to follow our contribution guide.

@RDIL RDIL changed the title [feature] Env can't be appveyor anymore [feature] Remove appveyor environment checks Jan 17, 2019
@RDIL
Copy link
Contributor Author

RDIL commented Jan 17, 2019

@iSazonov this good?

@iSazonov iSazonov changed the title [feature] Remove appveyor environment checks Remove appveyor environment checks Jan 17, 2019
daxian-dbw
daxian-dbw approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13 TravisEz13 merged commit f29a04c into PowerShell:master Jan 17, 2019
@TravisEz13
Copy link
Member

TravisEz13 commented Jan 17, 2019

Thanks @RDIL

@TravisEz13 TravisEz13 added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 17, 2019
@RDIL RDIL deleted the patch-2 branch January 17, 2019 20:42
@RDIL RDIL mentioned this pull request Jan 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@iSazonov iSazonov iSazonov approved these changes

+1 more reviewer

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RDIL @iSazonov @TravisEz13 @daxian-dbw @anmenaga