Skip to content

Contributing guidelines: Remove references to Travis CI and AppVeyor #8617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 2 commits into from
Jan 10, 2019
Merged

Contributing guidelines: Remove references to Travis CI and AppVeyor #8617

TravisEz13 merged 2 commits into from
Jan 10, 2019

Conversation

@RDIL
Copy link
Contributor

@RDIL RDIL commented Jan 9, 2019 •
edited by TravisEz13
Loading

PR Summary

Since when was Travis-CI used?? I removed it and replaced it with Azure DevOps because that isn't there.

PR Checklist

@vexx32
Copy link
Collaborator

vexx32 commented Jan 9, 2019

Travis CI stopped being used maybe a couple months ago? It was used for MacOS and Linux agents before we switched to Azure. 😄

@RDIL
Copy link
Contributor Author

RDIL commented Jan 9, 2019

Haha it was a rhetorical question but okay, at least this PR removes it.

@RDIL
Copy link
Contributor Author

RDIL commented Jan 9, 2019 •
edited
Loading

Not to be confused with @TravisEz13 @iSazonov

@RDIL RDIL mentioned this pull request Jan 9, 2019
Merged
11 tasks
@RDIL RDIL changed the title Contributing guidelines: Remove Travis CI Contributing guidelines: Remove Travis CI and AppVeyor Jan 9, 2019
@TravisEz13 TravisEz13 changed the title Contributing guidelines: Remove Travis CI and AppVeyor Contributing guidelines: Remove references Travis CI and AppVeyor Jan 9, 2019
@TravisEz13
Copy link
Member

TravisEz13 commented Jan 9, 2019

I edited your description to clarify this . #8617 (comment)

We are supposed to give 24 hours for review. If I don't, merge this by EOD tomorrow, feel free to ping me.

@RDIL RDIL changed the title Contributing guidelines: Remove references Travis CI and AppVeyor Contributing guidelines: Remove references to Travis CI and AppVeyor Jan 9, 2019
@RDIL
Copy link
Contributor Author

RDIL commented Jan 9, 2019

👍

@RDIL
Copy link
Contributor Author

RDIL commented Jan 10, 2019

@TravisEz13 its been about a day now.

@TravisEz13 TravisEz13 merged commit a3d5578 into PowerShell:master Jan 10, 2019
@TravisEz13 TravisEz13 added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jan 10, 2019
@RDIL RDIL deleted the patch-3 branch January 10, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@joeyaiello joeyaiello Awaiting requested review from joeyaiello

Assignees

@TravisEz13 TravisEz13

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RDIL @vexx32 @TravisEz13 @adityapatwardhan