Skip to content

Change Clear-Host back to using $RAWUI and clear to work over remoting - #8609

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:clear-host-fix
Jan 10, 2019
Merged

Change Clear-Host back to using $RAWUI and clear to work over remoting#8609
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:clear-host-fix

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Jan 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Based on feedback from Bruce Payette (@BrucePay) [Console]::Clear() only works locally and need to revert to using $RAWUI to clear the screen on Windows and clear command to clear on non-Windows so it works over remoting

This reverts part of the change in #8603

PR Checklist

@iSazonov

Ilya (iSazonov) commented Jan 9, 2019

Copy link
Copy Markdown
Collaborator

Maybe simply fallback to RawUI:

try {
    [Console]::Clear
} catch {
    # Use RawUI
}

@SteveL-MSFT Steve Lee (SteveL-MSFT) mentioned this pull request Jan 9, 2019
Closed
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jan 9, 2019

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) there's interest to convert this to a C# cmdlet and extend it, so let's defer any enhancements to that effort

@iSazonov

Ilya (iSazonov) commented Jan 10, 2019

Copy link
Copy Markdown
Collaborator

convert this to a C# cmdlet

Steve Lee (@SteveL-MSFT) Could you please open new Issue for this work? It seems this will be a breaking change and we will need PowerShell Committee approve.

@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 10, 2019
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jan 10, 2019

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) it's implicitly part of #8606 since the way Clear-Host is currently implemented it's impossible to extend

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 66c72c4 into PowerShell:master Jan 10, 2019
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the clear-host-fix branch January 10, 2019 18:44
@HumanEquivalentUnit HumanEquivalentUnit mentioned this pull request Jul 28, 2019
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @daxian-dbw
Change Clear-Host back to using $RAWUI and clear to work over r…
765058e 
…emoting (PowerShell#8609)
@iSazonov Ilya (iSazonov) mentioned this pull request Sep 29, 2026
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SteveL-MSFT @iSazonov @daxian-dbw