Skip to content

Update the name of the artifact to be unique per artifact #8405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 3 commits into from
Dec 6, 2018
Merged

Update the name of the artifact to be unique per artifact #8405

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2807094
[Feature] Update the name of the artifact to be unique per artifact
TravisEz13 Dec 5, 2018
4b92693
[Feature] remove appveyor code
TravisEz13 Dec 5, 2018
da7cc16
[feature] remove block on pushing artifacts for pull requests
TravisEz13 Dec 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions tools/appveyor.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,16 +517,23 @@ function Push-Artifact
param(
[Parameter(Mandatory)]
[ValidateScript({Test-Path -Path $_})]
$Path
$Path,
Copy link
Contributor

@PaulHigin PaulHigin Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be more clear if $Path was named $ArtifactPath and $Name to $ArtifactName.

[string]
$Name
)

if($env:Appveyor)
if(!$Name)
{
$artifactName = [system.io.path]::GetFileName($Path)
}
else
{
Push-AppveyorArtifact $Path
$artifactName = $Name
}
elseif ($env:TF_BUILD -and $env:BUILD_REASON -ne 'PullRequest') {

if ($env:TF_BUILD) {
Copy link
Contributor

@PaulHigin PaulHigin Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If $env:TF_BUILD is not defined then this cmdlet does nothing. Is that Ok, or should a warning be generated?

# In VSTS
Write-Host "##vso[artifact.upload containerfolder=artifacts;artifactname=artifacts;]$Path"
Write-Host "##vso[artifact.upload containerfolder=$artifactName;artifactname=$artifactName;]$Path"
}
}

Expand Down