Skip to content

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Dec 3, 2018

PR Summary

  • Remove dependabot attribution from change log.
  • Create sections in generated change log using the CL-* labels.

PR Checklist

@adityapatwardhan
Copy link
Member Author

@PaulHigin I updated the PRs, please have another look.

@@ -1,3 +1,5 @@
#requires -Version 6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our guidance says the copyright has to be first... This is obviously a reasonable exception, but should we update the guidance?

Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13 TravisEz13 merged commit 13cf8af into PowerShell:master Dec 3, 2018
@iSazonov
Copy link
Collaborator

iSazonov commented Dec 4, 2018

How do we track unlabeled commits and reverted commits?

@TravisEz13
Copy link
Member

if the commit was reverted in the same release use CL-NotInBuild for both the original and the revert commit.

The script will ward about any PRs without labels. Any final commits that are created during the release process outside of the PR process will have to be categorized manually.

@adityapatwardhan adityapatwardhan added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Dec 6, 2018
@adityapatwardhan adityapatwardhan deleted the UpdateCLScript branch January 8, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants