Skip to content

Expose all cmdlets from PSDiagnostics if logman.exe is available #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Dec 5, 2018
Merged

Expose all cmdlets from PSDiagnostics if logman.exe is available #8366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ab792f
change logic to expose compatible cmdlets in psdiagnostics
Nov 30, 2018
3ad8b7c
address Ilya's feedback
Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/Modules/Windows/PSDiagnostics/PSDiagnostics.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,12 +437,12 @@ namespace Microsoft.PowerShell.Diagnostics
}
"@

if ($psedition -eq 'Core')
{
# Currently we only support these cmdlets as logman.exe is not working on Nano/Lot system.
Export-ModuleMember Enable-PSTrace, Disable-PSTrace, Get-LogProperties, Set-LogProperties
}
else
{
Export-ModuleMember Start-Trace, Stop-Trace, Enable-WSManTrace, Disable-WSManTrace, Enable-PSTrace, Disable-PSTrace, Enable-PSWSManCombinedTrace, Disable-PSWSManCombinedTrace, Get-LogProperties, Set-LogProperties
}
if (Get-Command logman.exe -Type Application -ErrorAction SilentlyContinue)
Copy link
Collaborator

@iSazonov iSazonov Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a comment about Nano/IoT will be still useful.

Copy link
Collaborator

@iSazonov iSazonov Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveL-MSFT Could you clarify whether this comment is needed?

Copy link
Member Author

@SteveL-MSFT SteveL-MSFT Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment still exists on line 446

{
Export-ModuleMember Disable-PSTrace, Disable-PSWSManCombinedTrace, Disable-WSManTrace, Enable-PSTrace, Enable-PSWSManCombinedTrace, Enable-WSManTrace, Get-LogProperties, Set-LogProperties, Start-Trace, Stop-Trace
}
else
{
# Currently we only support these cmdlets as logman.exe is not available on systems like Nano and IoT
Export-ModuleMember Disable-PSTrace, Enable-PSTrace, Get-LogProperties, Set-LogProperties
}