Expose all cmdlets from PSDiagnostics if logman.exe is available #8366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
approved these changes
Nov 30, 2018
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
@SteveL-MSFT Can your team add CI for Nano/IoT/Windows 7 x32 if it is important?
iSazonov
added
the
CL-General
Member
Author
|
@iSazonov we're working on improving our release automation which includes running tests daily on all supported distros/skus. Don't think Nano nor Win10 IoT will be there initially. I expect Win7, but not x86 initially if that's what you mean. |
iSazonov
reviewed
Nov 30, 2018
| { | ||
| Export-ModuleMember Start-Trace, Stop-Trace, Enable-WSManTrace, Disable-WSManTrace, Enable-PSTrace, Disable-PSTrace, Enable-PSWSManCombinedTrace, Disable-PSWSManCombinedTrace, Get-LogProperties, Set-LogProperties | ||
| } | ||
| if (Get-Command logman.exe -Type Application -ErrorAction SilentlyContinue) |
Collaborator
There was a problem hiding this comment.
Seems a comment about Nano/IoT will be still useful.
Collaborator
There was a problem hiding this comment.
@SteveL-MSFT Could you clarify whether this comment is needed?
Member
Author
There was a problem hiding this comment.
The comment still exists on line 446
daxian-dbw
approved these changes
Dec 4, 2018
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PSDiagnostics had outdated logic to expose cmdlets for PSCore5 where logman.exe didn't exist, but this is no longer the case with PSCore6 on full Windows. Change logic to check for existence of logman.exe in path rather than assume Core vs Desktop PowerShell. Deferring adding tests for these cmdlets as it seems we don't have any tests for PSDiagnostics module: #8367
Fix #8339
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests