Skip to content

Added SelfSignedCertificate module to the test package #8350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 1 commit into from
Nov 30, 2018
Merged

Added SelfSignedCertificate module to the test package #8350

adityapatwardhan merged 1 commit into from
Nov 30, 2018

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Nov 28, 2018 •
edited
Loading

PR Summary

The test package is missing the SelfSignedCertificate module, which is downloaded from the gallery. This change adds that module to the appropriate location for packaging.

PR Checklist

@adityapatwardhan
Copy link
Member Author

adityapatwardhan commented Nov 28, 2018

I have verified by running the function New-TestPackage that the module is included.

rjmholt
rjmholt approved these changes Nov 28, 2018
View reviewed changes
Copy link
Collaborator

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adityapatwardhan
Copy link
Member Author

adityapatwardhan commented Nov 30, 2018

@rjmholt can you have another look.

rjmholt
rjmholt approved these changes Nov 30, 2018
View reviewed changes
Copy link
Collaborator

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TravisEz13
Copy link
Member

TravisEz13 commented Nov 30, 2018

make sure dependabot detects the new csproj after merging

@adityapatwardhan adityapatwardhan merged commit 3794a5e into PowerShell:master Nov 30, 2018
@adityapatwardhan adityapatwardhan deleted the FixTestPackage branch November 30, 2018 19:49
@adityapatwardhan adityapatwardhan added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

+2 more reviewers

@rjmholt rjmholt rjmholt approved these changes

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adityapatwardhan @TravisEz13 @rjmholt @PaulHigin