Skip to content

[improvement] removed comments after closing brackets - #8344

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
Meir017:improvements/clean-comments
Dec 8, 2018
Merged

Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
Meir017:improvements/clean-comments

Conversation

@Meir017

@Meir017 Meir Blachman (Meir017) commented Nov 27, 2018 •

Copy link
Copy Markdown
Contributor

PR Summary

Removed all comments that appear after a closing bracket
idea came from #8324 (comment)

since any time a pull-request will be authored on a file the contains these comments the pull-request creator will be asked to remove them I thought might be a good idea to do this once and finish with it

PR Checklist

@iSazonov

Copy link
Copy Markdown
Collaborator

Meir Blachman (@Meir017) In future please keep PR as small as possible: small PR can be reviewed fast. You could create some PRs by folder/projects. Another approach is to make some commits (by 10-15 files) in one PR that allow fast review commit by commit or break work into several people.

@iSazonov Ilya (iSazonov) self-assigned this Nov 29, 2018
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 29, 2018
@Meir017

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) I thought about splitting it into multiple pull-requests but since it was just a regex-replace action I thought it might be easier to do it this way.
In the future I'll make smaller pull-requests 😄

@iSazonov

Copy link
Copy Markdown
Collaborator

Meir Blachman (@Meir017) You could make some commits to allow commit-by-commit review.

@iSazonov

Copy link
Copy Markdown
Collaborator

Double checked.

@iSazonov
Ilya (iSazonov) merged commit b7b386d into PowerShell:master Dec 8, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants