Cleanup '#if !CORECLR' code #8337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
requested review from
BrucePay,
PaulHigin,
anmenaga and
mirichmo
as code owners
iSazonov
force-pushed
the
cleanup-corecrl2
branch
from
af4245f to
cc33627
Compare
iSazonov
requested review from
TravisEz13 and
adityapatwardhan
as code owners
TravisEz13
approved these changes
Nov 26, 2018
anmenaga
reviewed
Nov 28, 2018
| , RegistryKeyPermissionCheck.ReadWriteSubTree | ||
| #endif | ||
| ); | ||
| Credential_Delegation_Key = rootKey.CreateSubKey(Registry_Path_Credentials_Delegation, RegistryKeyPermissionCheck.ReadWriteSubTree); |
There was a problem hiding this comment.
Why did you decide to add RegistryKeyPermissionCheck parameter here?
It looks like the macro was removing it previously...
Collaborator
Author
There was a problem hiding this comment.
I guess it was removed because CoreFX had not support. Now we have this and we can enable the check.
SteveL-MSFT
requested changes
Nov 28, 2018
src/System.Management.Automation/engine/remoting/fanin/BaseTransportManager.cs
Show resolved
Hide resolved
iSazonov
added
the
CL-CodeCleanup
SteveL-MSFT
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Related #3565 and #4357.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests