Skip to content

Remove old 'customPSSnapInType' parameter from PSSnapInInfo() - #8333

Merged
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
iSazonov:cleanup-pssnapininfo
Nov 26, 2018
Merged

Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
iSazonov:cleanup-pssnapininfo

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Nov 23, 2018 •

Copy link
Copy Markdown
Collaborator

PR Summary

Related #3565 and #4357.

CustomPSSnapIn is not supported in PowerShell Core and we can remove the old 'customPSSnapInType' parameter from internal API.

PR Checklist

@iSazonov Ilya (iSazonov) self-assigned this Nov 23, 2018
@iSazonov Ilya (iSazonov) changed the title [Feature] Remove old 'customPSSnapInType' parameter from PSSnapInInfo() Remove old 'customPSSnapInType' parameter from PSSnapInInfo() Nov 23, 2018

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please remove the unneeded resource string.

{
throw PSTraceSource.NewArgumentException(
"customPSSnapInType",
MshSnapInCmdletResources.CustomPSSnapInNotSupportedInPowerShellCore);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this resource string from the .resx file?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@iSazonov
Ilya (iSazonov) merged commit e2b5aac into PowerShell:master Nov 26, 2018
@iSazonov
Ilya (iSazonov) deleted the cleanup-pssnapininfo branch November 26, 2018 06:21
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 26, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants