Skip to content

Skip tests on Appveyor due to PSReadline issue #8317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 4 commits into from
Nov 20, 2018
Merged

Skip tests on Appveyor due to PSReadline issue #8317

adityapatwardhan merged 4 commits into from
Nov 20, 2018

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Nov 20, 2018 •
edited
Loading

PR Summary

Enter-PSHostProcess tests fail on AppVeyor due to PSReadline issue. This change skips the tests on AppVeyor.

Expected 3948, but got @(<empty>, 'Oops, something went wrong.  Please report this bug with the details below.', 'Report on GitHub: https://github.com/lzybkr/PSReadLine/issues/new', '-----------------------------------------------------------------------', 'Last 0 Keys:', '```', <empty>, '```', <empty>, 'Exception:').

PR Checklist

@adityapatwardhan adityapatwardhan changed the title [Feature] Skip tests on Appveyor due to PSReadline issue Skip tests on Appveyor due to PSReadline issue Nov 20, 2018
@anmenaga
Copy link

anmenaga commented Nov 20, 2018

Something is not right; CI's are failing for this change.

@adityapatwardhan adityapatwardhan force-pushed the FixEnterPSHostProcessTests branch from 5a0d7dd to 561d550 Compare November 20, 2018 02:12
@adityapatwardhan adityapatwardhan merged commit f27dfea into PowerShell:master Nov 20, 2018
@adityapatwardhan adityapatwardhan deleted the FixEnterPSHostProcessTests branch November 20, 2018 18:17
@adityapatwardhan adityapatwardhan added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Nov 21, 2018
iSazonov pushed a commit to iSazonov/PowerShell that referenced this pull request Nov 29, 2018
@adityapatwardhan @iSazonov
Skip Enter-PSHostProcess tests on Appveyor due to PSReadline issue (P…
336b7be 
…owerShell#8317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adityapatwardhan @anmenaga @SteveL-MSFT