Fix for PSDrive creation with a UNC path with a trailing backslash or forward slash when combined with -Persist #8305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvprasoon
requested review from
adityapatwardhan and
daxian-dbw
as code owners
iSazonov
reviewed
Nov 18, 2018
src/Microsoft.PowerShell.Commands.Management/commands/management/Navigation.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
@kvprasoon Please make the PR title more meaningful and add tests. |
kvprasoon
changed the title
iSazonov
reviewed
Nov 21, 2018
test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
added
the
CL-General
iSazonov
reviewed
Nov 23, 2018
test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Nov 24, 2018
test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Management/New-PSDrive.Tests.ps1
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Management/New-PSDrive.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
approved these changes
Nov 25, 2018
SteveL-MSFT
requested changes
Nov 27, 2018
test/powershell/Modules/Microsoft.PowerShell.Management/New-PSDrive.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Management/New-PSDrive.Tests.ps1
Outdated
Show resolved
Hide resolved
Collaborator
|
@kvprasoon Please resolve merge conflicts and address comments. |
Contributor
Author
|
@iSazonov Done 👍 |
Collaborator
|
@kvprasoon Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Close #8242
Fix for PSDrive creation with a UNC path with a trailing backslash or forward slash when combined with -Persist
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests